Skip to content

Use result type for TR_Result instead of union #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use result type for TR_Result instead of union #875

wants to merge 1 commit into from
+30 −33

Conversation

trdthg
Copy link
Contributor

@trdthg trdthg commented Apr 22, 2025 •
edited
Loading

last part of #433

Same with #872, retained two ext_ptw result(('paddr, ext_ptw), ('failure, ext_ptw)) now

@github-actions GitHub Actions
Copy link

Test Results

400 tests  ±0   400 ✅ ±0   1m 48s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit c18b463. ± Comparison against base commit a811d52.

@pmundkur
Copy link
Collaborator

Some of this is already handled in the simplifications from #861; the rest (riscv_fetch*, riscv_insts_zicbo{m,z}, riscv_vmem.sail and part of riscv_insts_aext.sail) is still useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timmmm Timmmm Timmmm approved these changes

@jordancarlin jordancarlin jordancarlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trdthg @pmundkur @Timmmm @jordancarlin