-
Notifications
You must be signed in to change notification settings - Fork 204
CI: test ./build_emulators.sh #876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
See #745 and somehow we need a mirror of gmp. |
Go and see https://github.com/Arielfoever/sail-riscv/actions/runs/14591059685/job/40926223320 if it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to get this in, but I don't think this CI job will work until the issue with downloading GMP is addressed (#745 (comment)).
5c06d9c
to
09af9d5
Compare
Building the simulator twice just to test the shell script seems quite wasteful, why not instead adapt the existing build job to use the script? |
That seems reasonable. If we want to make sure that the build works with both static and dynamic gmp, we could also have the build with the shell script happen on a weekly schedule instead of for every PR. Most code changes are unlikely to break it, so that is probably more than sufficient to make sure the script continues working. |
Fix via #882 |
I would agree with you but I suggest that put these two into repo for some time. When everything's fine we can remove another one. |
Signed-off-by: Ariel Xiong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think it probably makes sense to make it be another job in compile.yml
instead of a new file.
|
||
- name: Build simulator | ||
run: ./build_simulators.sh | ||
# Build with ./build_emulators.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Build with ./build_emulators.sh |
- name: Test simulator | ||
run: ctest --test-dir build --output-junit tests.xml --output-on-failure | ||
|
||
- name: Upload test results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need to upload the test results/event payload since the other workflow will already do this.
@@ -0,0 +1,40 @@ | |||
name: CI with script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: CI with script | |
name: Test build_emulators.sh script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is duplicating quite a lot - can we just add another matrix combination to the main CI build?
I think something like this could possibly work?
strategy:
matrix:
os: [macos-latest, ubuntu-latest]
include:
- os: ubuntu-latest
variant: build-emulators
I think a variant might get complicated. We could potentially use composite actions to add it as a job without duplicating everything though. I've never used them before so I'm not really sure... |
Add a build by build_emulators.sh and I believe there's no need to test.