-
Notifications
You must be signed in to change notification settings - Fork 204
Add a project version to the build. #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pmundkur
wants to merge
1
commit into
riscv:master
Choose a base branch
from
pmundkur:version_info
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
#pragma once | ||
|
||
#define SAIL_RISCV_VERSION "@sail_riscv_git_version@" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
# Set a default version for archive builds that do not have | ||
# git history. Increment this appropriately at tag-and-release time. | ||
set(archive_build_version "0.7.0") | ||
|
||
# Sets GIT_EXECUTABLE | ||
find_package(Git REQUIRED) | ||
|
||
# We could remove --tags if we started annotating the release tags. | ||
execute_process( | ||
COMMAND ${GIT_EXECUTABLE} describe --tags HEAD | ||
RESULT_VARIABLE git_error | ||
OUTPUT_VARIABLE git_describe | ||
OUTPUT_STRIP_TRAILING_WHITESPACE | ||
) | ||
|
||
if (git_error) | ||
message(STATUS "Failed to run git describe: ${git_error}") | ||
|
||
set(sail_riscv_git_version ${archive_build_version}) | ||
set(sail_riscv_cmake_version ${archive_build_version}) | ||
else() | ||
# `git describe` cannot directly be used as a CMake VERSION argument | ||
# for project() due the trailing commit hash failing CMake's semver | ||
# format check. | ||
# | ||
# We could directly set PROJECT_VERSION to ${git_describe}, but that | ||
# makes it incompatible with CPack in case we decide to use it. | ||
# https://gitlab.kitware.com/cmake/cmake/-/issues/16716#note_956803 | ||
# | ||
# Instead, parse the version components for CMake and CPack, and use | ||
# git_describe for the simulator --version. | ||
|
||
if (git_describe MATCHES "^([0-9]+)\\.([0-9]+)(-.*)?$") | ||
set(v_major ${CMAKE_MATCH_1}) | ||
set(v_minor ${CMAKE_MATCH_2}) | ||
else() | ||
message(FATAL_ERROR "Cannot parse git describe output: ${git_describe}") | ||
endif() | ||
|
||
set(sail_riscv_git_version ${git_describe}) | ||
set(sail_riscv_cmake_version "${v_major}.${v_minor}") | ||
endif() | ||
|
||
# Log versions in the build log. | ||
message(STATUS "Building versions: ${sail_riscv_git_version} (git), ${sail_riscv_cmake_version} (cmake).") |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we have to do this anyway is there much benefit to using
git describe
?I wonder if it's simpler just to update it manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
git describe
would be useful for users who don't wait for released versions, e.g. the ACT folks (see #850). I think they also originated the discussion in #109.