Skip to content

Fix the '--help' option. #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025
Merged

Fix the '--help' option. #888

merged 1 commit into from
Apr 27, 2025

Conversation

pmundkur
Copy link
Collaborator

It was not handled correctly (unlike '-h'), resulting in a confusing No elf file provided. message before the help text.

Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was accidentally introduced in 17cfdec

Could you update the commit message to add that it fixes a regression from 17cfdec?

Copy link

github-actions bot commented Apr 25, 2025

Test Results

400 tests  ±0   400 ✅ ±0   1m 55s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit cc58a5f. ± Comparison against base commit 5872942.

♻️ This comment has been updated with latest results.

It fixes a regression introduced in 17cfdec which resulted in a
confusing `No elf file provided.` message before the help text.
@Timmmm Timmmm added the will be merged Scheduled to be merged in a few days if nobody objects label Apr 25, 2025
@Timmmm Timmmm merged commit e4975fc into riscv:master Apr 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
will be merged Scheduled to be merged in a few days if nobody objects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants