Skip to content

Updating CI Linting and Build.ymls#648

Merged
brettpac merged 1 commit intohumblefrom
brettpac_branch
Nov 2, 2025
Merged

Updating CI Linting and Build.ymls#648
brettpac merged 1 commit intohumblefrom
brettpac_branch

Conversation

@brettpac
Copy link
Collaborator

@brettpac brettpac commented Nov 1, 2025

Here's a summary of the changes:


📄 1. ci-ros-lint.yaml

Changes Made:

  • ✅ Updated OS: ubuntu-20.04 → ubuntu-22.04
  • ✅ Updated ROS distro: galactic → humble
  • ✅ Removed deleted packages:
    • sm_atomic_performance_test
    • sm_atomic_subscribers_performance_test
  • ✅ Added all 14 current state machines (including 5 new ones):
    • sm_atomic_http (new)
    • sm_cl_keyboard_unit_test_1 (new)
    • sm_cl_ros2_timer_unit_test_1 (new)
    • sm_panda_cl_moveit2z_cb_inventory (new)
    • sm_simple_action_client (new)
    • Plus all other existing state machines

📄 2. humble-binary-build.yml

Changes Made:

  • ✅ Removed 20 non-existent packages from skip list:
    • sm_multi_ur5_sim, sm_atomic_hierarchy, sm_dance_bot_warehouse_2, sm_dance_bot_warehouse_3, sm_dance_bot, sm_dance_bot_strikes_back, sm_ferrari, sm_pubsub_1, sm_atomic_services,
      sm_multi_panda_sim, sm_respira_1, sm_atomic_24hr, sm_autoware_avp, sm_dance_bot_warehouse, sm_dancebot_ue, sm_dancebot_artgallery_ue, sm_dancebot_fashion_ue, sm_dancebot_mine_ue,
      sm_dancebot_office_ue
  • ✅ Added sm_panda_cl_moveit2z_cb_inventory to skip list (MoveIt2 dependency)
  • ✅ Added comprehensive comments documenting why packages are skipped:
    • MoveIt2-dependent packages
    • ML dependencies
    • Special testing/development packages
    • Complex scenarios
  • ✅ Final skip list (10 packages):
    • sm_panda_moveit2z_cb_inventory (MoveIt2)
    • sm_panda_cl_moveit2z_cb_inventory (MoveIt2)
    • sm_pack_ml (ML dependencies)
    • sm_atomic (testing)
    • sm_atomic_lifecycle (testing)
    • sm_atomic_mode_states (testing)
    • sm_advanced_recovery_1 (complex)
    • sm_branching (complex)
    • sm_multi_stage_1 (complex)
    • sm_three_some (complex)

📄 3. humble-semi-binary-build.yml

Changes Made:

  • ✅ Removed 17 non-existent packages from skip list (same as binary build minus a few)
  • ✅ Added sm_panda_cl_moveit2z_cb_inventory to skip list
  • ✅ Added same comprehensive comments as binary build
  • ✅ Final skip list (10 packages): Same as binary build for consistency

📊 Impact Summary

Packages Now Included in CI (that weren't before):

  • sm_atomic_http
  • sm_cl_keyboard_unit_test_1
  • sm_cl_ros2_timer_unit_test_1
  • sm_simple_action_client

Net Result:

  • Removed: 20 non-existent package references from builds
  • Added: 5 new packages to linting
  • Added: 1 new package to skip lists (sm_panda_cl_moveit2z_cb_inventory)
  • Updated: ROS distribution and OS version for future compatibility
  • Documented: Clear rationale for all skipped packages

@brettpac brettpac merged commit 28529cc into humble Nov 2, 2025
5 checks passed
@brettpac brettpac deleted the brettpac_branch branch November 2, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant