[Spawner] Accept parsing multiple --param-file arguments to spawner
#1805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
DasRoteSkelett,
VX792,
arne48,
bmagyar,
destogl,
mcbed and
olivier-stasse
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1805 +/- ##
==========================================
- Coverage 87.97% 87.91% -0.07%
==========================================
Files 121 121
Lines 12403 12491 +88
Branches 1105 1121 +16
==========================================
+ Hits 10912 10981 +69
- Misses 1085 1103 +18
- Partials 406 407 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saikishor
changed the title
saikishor
changed the title
--param-file arguments to spawner
christophfroehlich
requested changes
Oct 25, 2024
Member
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
Seems to be a good idea, and implementation LGTM.
Please update the doc section and release notes.
Member
Author
@christophfroehlich Done |
saikishor
commented
Oct 27, 2024
Contributor
|
This pull request is in conflict. Could you fix it @saikishor? |
christophfroehlich
previously approved these changes
Nov 2, 2024
saikishor
added
backport-humble
Contributor
|
This pull request is in conflict. Could you fix it @saikishor? |
christophfroehlich
previously approved these changes
Nov 11, 2024
Contributor
|
This pull request is in conflict. Could you fix it @saikishor? |
Co-authored-by: Christoph Fröhlich <[email protected]>
saikishor
force-pushed
the
extend/spawner/parameter_file_parsing
branch
from
6e131e9 to
5c79dd5
Compare
bmagyar
reviewed
Nov 28, 2024
bmagyar
approved these changes
Nov 28, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
…#1805) (cherry picked from commit 73fe227) # Conflicts: # controller_manager/controller_manager/controller_manager_services.py # controller_manager/controller_manager/launch_utils.py # controller_manager/controller_manager/spawner.py # controller_manager/src/controller_manager.cpp # controller_manager/test/test_spawner_unspawner.cpp # doc/release_notes.rst # ros2controlcli/ros2controlcli/verb/load_controller.py
saikishor
added a commit
that referenced
this pull request
Dec 3, 2024
christophfroehlich
pushed a commit
that referenced
this pull request
Dec 3, 2024
… (backport #1805) (#1894) --------- Co-authored-by: Sai Kishor Kothakota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use multiple controlers to activate or deactivate, it is quite cumbersome to accept only one
--param-filearg as it is not very scalable. For this reason, now the spawner can accept multiple --param-file args and set the respective param_file to those corresponding controllers.Along with the above mentioned change, now the controllers can accept multiple param-file args as well, and this is very helpful to be able to override parameters between parameter files as how it is done with the standard ROS 2 nodes