Remove the dangling param flag for robot_description with parameter

[saikishor]

Fixes #2082 (comment)

Initially, when we suppressed the warning we only handled the case of the robot_description parsed using topics but not the parameter.

@lukicdarkoo Can you check this change and let us know :)

[christophfroehlich]

@lukicdarkoo we have deprecated the robot_description parameter in humble and removed it from jazzy on. Why do you need this in webots?

[christophfroehlich]

We don't support robot_description from parameters any more, but this improves robustness

[lukicdarkoo]

@christophfroehlich We just pass all arguments to the controller manager:
https://github.com/cyberbotics/webots_ros2/blob/7435cfba110794900641cf57e5b33dfd07badaca/webots_ros2_control/src/Ros2Control.cpp#L161-L163

We use it for some other purposes before passing it to the controller manager.

Alternatively, we can remove the robot_description parameter from the list.

But in any case, if the user passes the -p robot_description:=xyz it shouldn't produce -p and eventually crash.

[christophfroehlich]

@saikishor should we add a test for that to prevent that in the future? 🤷‍♂️

[saikishor]

@saikishor should we add a test for that to prevent that in the future? 🤷‍♂️

I was relying on the tests from ros2_control_demos🙈

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.29%. Comparing base (526a017) to head (28d2f78).
Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
controller_manager/src/controller_manager.cpp	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2115      +/-   ##
==========================================
- Coverage   89.30%   89.29%   -0.02%     
==========================================
  Files         139      139              
  Lines       15500    15502       +2     
  Branches     1318     1318              
==========================================
- Hits        13843    13842       -1     
- Misses       1154     1156       +2     
- Partials      503      504       +1     

Flag	Coverage Δ
unittests	89.29% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
controller_manager/src/controller_manager.cpp	76.32% <0.00%> (-0.16%)	⬇️

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[lukicdarkoo]

Tested, it works! Thank you!