-
Notifications
You must be signed in to change notification settings - Fork 395
Add has_state and has_command to hw_component_if
#2701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
saikishor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add a test where a particular state interface exists but not the command interface?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2701 +/- ##
=======================================
Coverage 89.33% 89.33%
=======================================
Files 151 151
Lines 17143 17147 +4
Branches 1432 1432
=======================================
+ Hits 15314 15318 +4
Misses 1247 1247
Partials 582 582
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Co-authored-by: Sai Kishor Kothakota <[email protected]>
|
Perfectoooo |
A helper for easier logic inside of hardware components, for reference see #2694