Skip to content

Conversation

@christophfroehlich
Copy link
Member

A helper for easier logic inside of hardware components, for reference see #2694

@christophfroehlich christophfroehlich added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Oct 18, 2025
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a test where a particular state interface exists but not the command interface?

@codecov
Copy link

codecov bot commented Oct 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.33%. Comparing base (a27c528) to head (eafa27b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2701   +/-   ##
=======================================
  Coverage   89.33%   89.33%           
=======================================
  Files         151      151           
  Lines       17143    17147    +4     
  Branches     1432     1432           
=======================================
+ Hits        15314    15318    +4     
  Misses       1247     1247           
  Partials      582      582           
Flag Coverage Δ
unittests 89.33% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ardware_interface/hardware_component_interface.hpp 78.01% <100.00%> (+0.31%) ⬆️
...dware_interface/test/test_component_interfaces.cpp 97.88% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich
Copy link
Member Author

Can we also add a test where a particular state interface exists but not the command interface?

eafa27b?

@saikishor
Copy link
Member

Can we also add a test where a particular state interface exists but not the command interface?

eafa27b?

Perfectoooo

@saikishor saikishor merged commit 6d27e9d into master Oct 18, 2025
16 of 17 checks passed
@saikishor saikishor deleted the add/has_interface branch October 18, 2025 11:09
mergify bot pushed a commit that referenced this pull request Oct 18, 2025
…face (#2701)

(cherry picked from commit 6d27e9d)

# Conflicts:
#	hardware_interface/include/hardware_interface/hardware_component_interface.hpp
mergify bot pushed a commit that referenced this pull request Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants