Skip to content

Conversation

@christophfroehlich
Copy link
Member

I found some obsolete code and did some cleanup like unreachable statements and unnecessary test class friending.

@christophfroehlich christophfroehlich changed the title Cleanup GenericSystem Cleanup GenericSystem code 🧹 Oct 18, 2025
@christophfroehlich christophfroehlich changed the title Cleanup GenericSystem code 🧹 Cleanup GenericSystem component code 🧹 Oct 18, 2025
@codecov
Copy link

codecov bot commented Oct 18, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.40%. Comparing base (8ad5ebb) to head (9300df6).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...e_interface/src/mock_components/generic_system.cpp 70.37% 0 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2706      +/-   ##
==========================================
- Coverage   89.40%   89.40%   -0.01%     
==========================================
  Files         151      151              
  Lines       17225    17209      -16     
  Branches     1431     1429       -2     
==========================================
- Hits        15400    15385      -15     
+ Misses       1246     1244       -2     
- Partials      579      580       +1     
Flag Coverage Δ
unittests 89.40% <71.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...terface/include/mock_components/generic_system.hpp 100.00% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 99.76% <100.00%> (+<0.01%) ⬆️
...e_interface/src/mock_components/generic_system.cpp 85.82% <70.37%> (-0.51%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saikishor saikishor added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Oct 20, 2025
@christophfroehlich christophfroehlich merged commit 9a9c8a9 into master Oct 20, 2025
17 of 19 checks passed
@christophfroehlich christophfroehlich deleted the cleanup/mock branch October 20, 2025 07:50
mergify bot pushed a commit that referenced this pull request Oct 20, 2025
mergify bot pushed a commit that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants