Migrate deprecated tf2/message_filters headers to .hpp#574
Open
wolfv wants to merge 1 commit into
Open
Conversation
The .h headers for tf2, tf2_ros and message_filters were deprecated in favour of .hpp and have since been removed on Rolling, so the package fails to build there. The .hpp headers are available on all currently supported distros (Humble, Jazzy, Kilted), so switch to them unconditionally. This covers velodyne_pointcloud and the one remaining include in velodyne_driver. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
I guess that's what is blocking Lyrical.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.hheaders fortf2,tf2_rosandmessage_filterswere deprecated in favour of.hppversions and have since been removed on Rolling, sovelodyne_pointcloud/velodyne_drivercurrently fail to build there (this is what surfaced while packaging velodyne for RoboStack).The
.hppheaders are available on all currently supported distros — I verifiedbuffer_core,exceptions,LinearMath/Quaternion,LinearMath/Vector3,tf2_ros/{buffer,transform_listener,message_filter}andmessage_filters/subscriberall exist as.hppon Humble, Jazzy and Kilted — so the switch is unconditional and needs no version guards.Changes are limited to swapping the include extensions; no code/logic changes. Covers
velodyne_pointcloudand the one remaining include invelodyne_driver.