Improvement/cldsrv 724 bucket related functional tests #5988

benzekrimaha · 2025-10-27T16:40:28Z

bert-e · 2025-10-27T16:40:32Z

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-10-27T16:40:43Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

codecov · 2025-10-27T16:46:46Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.35%. Comparing base (046c9a7) to head (84669aa).
⚠️ Report is 186 commits behind head on improvement/CLDSRV-724-object-related-functional-tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files

see 73 files with indirect coverage changes

@@                                    Coverage Diff                                     @@
##           improvement/CLDSRV-724-object-related-functional-tests    #5988      +/-   ##
==========================================================================================
+ Coverage                                                   77.51%   84.35%   +6.83%     
==========================================================================================
  Files                                                         191      204      +13     
  Lines                                                       12233    12928     +695     
==========================================================================================
+ Hits                                                         9483    10906    +1423     
+ Misses                                                       2750     2022     -728

Flag	Coverage Δ
quota-tests	`?`
quota-tests-inflights	`?`
unit	`69.92% <ø> (+1.59%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ghost · 2025-10-28T08:17:51Z

tests/functional/aws-node-sdk/test/bucket/aclUsingPredefinedGroups.js

+                    .then(() => awsRequest(auth, ListObjectsV2Command, { Bucket: testBucket }))
+                    .then(() => done(new Error('Expected failure')))
+                    .catch(cbWithError(done));
+                // Don't return the promise!


Suggested change

// Don't return the promise!

ghost · 2025-10-28T08:20:15Z

tests/functional/aws-node-sdk/test/bucket/put.js

+                // Use unique bucket name for each test to avoid conflicts
+                testBucketName = `${bucketName}-${Date.now()}-${Math.random().toString(36).substr(2, 9)}`;


Could probably be a helper function later shared with all tests?

ghost · 2025-10-28T08:20:59Z

tests/functional/aws-node-sdk/test/bucket/putBucketReplication.js

-
+        }
+    });
+    


Suggested change

tests/functional/aws-node-sdk/test/bucket/skipScan.js

ghost · 2025-10-28T08:22:00Z

tests/functional/aws-node-sdk/test/quota/tooling.js

+    const [pathBase, queryString] = path.split('?');
+    const query = queryString ? Object.fromEntries(new URLSearchParams(queryString)) : {};
+
+    // Create HTTP request (mimics AWS.HttpRequest with v2-like endpoint structure)


Suggested change

// Create HTTP request (mimics AWS.HttpRequest with v2-like endpoint structure)

// Create HTTP request

ghost · 2025-10-28T08:22:31Z

tests/functional/aws-node-sdk/test/quota/tooling.js

+    // Rename 'authorization' to 'Authorization'
+    if (signedRequest.headers.authorization) {
+        signedRequest.headers.Authorization = signedRequest.headers.authorization;
+        delete signedRequest.headers.authorization;


Is this needed? in node the headers are always lowercased

DarkIsDude

Congrats again 👏

DarkIsDude · 2025-12-05T21:45:36Z

tests/functional/aws-node-sdk/test/bucket/aclUsingPredefinedGroups.js

+            // Create unsigned client
+            const unsignedClient = new BucketUtility('default', {
+                ...sigCfg,
+                credentials: { accessKeyId: '', secretAccessKey: '' },
+                forcePathStyle: true,
+                signer: { sign: async request => request },
+            });
+
+            // Replace awsAuthMiddleware with a no-op middleware to skip signing


Suggested change

// Create unsigned client

const unsignedClient = new BucketUtility('default', {

...sigCfg,

credentials: { accessKeyId: '', secretAccessKey: '' },

forcePathStyle: true,

signer: { sign: async request => request },

});

// Replace awsAuthMiddleware with a no-op middleware to skip signing

const unsignedClient = new BucketUtility('default', {

...sigCfg,

credentials: { accessKeyId: '', secretAccessKey: '' },

forcePathStyle: true,

signer: { sign: async request => request },

});

DarkIsDude · 2025-12-05T21:46:07Z

tests/functional/aws-node-sdk/test/bucket/aclUsingPredefinedGroups.js

+                    .then(() => awsRequest(auth, ListObjectsV2Command, { Bucket: testBucket }))
+                    .then(() => done(new Error('Expected failure')))
+                    .catch(cbWithError(done));
+                // Don't return the promise!


DarkIsDude · 2025-12-05T21:47:41Z

tests/functional/aws-node-sdk/test/bucket/bucketPolicyWithResourceStatements.js

+                'getObject': GetObjectCommand,
+                'putObject': PutObjectCommand,
+            };
+            const CommandCtor = commandMap[operation];


CommandCtor what does it mean ?

ia said commandConstructor, but i also didnt find it myself

it is just a diminutif for commandConstructor, used later on in this code

tests/functional/aws-node-sdk/test/bucket/deleteBucketLifecycle.js

tests/functional/aws-node-sdk/test/bucket/getBucketLogging.js

tests/functional/aws-node-sdk/test/bucket/getLocation.js

tests/functional/aws-node-sdk/test/bucket/skipScan.js

tests/functional/aws-node-sdk/test/bucket/deleteBucketPolicy.js

SylvainSenechal · 2025-12-08T10:25:04Z

tests/functional/aws-node-sdk/test/bucket/getBucketLifecycle.js

+                Expiration: { Days: 1 },
+                ID: 'test-id',
+                Prefix: '',
+                Status: 'Enabled',


Transitions and nunCurrentVersions transitions are undefined instead of [], right ?

yes that's why they're not here the sdk v3 no longer returns the fields when undefined, if ever present I did the adjustment to not have to extend the changes even more

tests/functional/aws-node-sdk/test/bucket/listingCornerCases.js

SylvainSenechal · 2025-12-08T11:22:38Z

tests/functional/aws-node-sdk/test/bucket/put.js

+                const res = await bucketUtil.s3.send(new CreateBucketCommand({
+                    Bucket: testBucketName,
                    CreateBucketConfiguration: {
-                        LocationConstraint: 'scality-us-west-1',


Did something failed with the old location constraint ? Is it related to the comment above ?

SylvainSenechal · 2025-12-08T13:09:03Z

tests/functional/aws-node-sdk/test/bucket/putBucketLifecycle.js

            });
        });

-        // NoncurrentVersionTransitions not implemented


it's a bit weird that you removed the comment, but the test is still skipped. Is it implemented and needs to be tested now ?

SylvainSenechal · 2025-12-08T13:13:58Z

tests/functional/aws-node-sdk/test/bucket/putBucketLifecycle.js

-                            ID: 'id2',
-                            Status: 'Enabled',
-                            Prefix: '',
-                            Expiration: {


Can you give some context about this changes, Expiration got removed. Also I feel like some tests were removed, or some of them renamed, its a bit hard to track the diff, sometimes the Days parameter is changed from 0 to 1, but sometimes its not changes

SylvainSenechal · 2025-12-08T13:34:44Z

tests/functional/aws-node-sdk/test/bucket/skipScan.js

-                if (err) {
-                    done(err, data);
-                }
-                /* generating different prefixes every x > STREAK_LENGTH


better to keep this ?

SylvainSenechal

only nits and a few questions, but approved alr

Issue: CLDSRV-724

benzekrimaha changed the base branch from development/9.1 to improvement/CLDSRV-724-object-related-functional-tests October 27, 2025 16:40

benzekrimaha force-pushed the improvement/CLDSRV-724-bucket-related-functional-tests branch 3 times, most recently from 834eefe to 92f36a8 Compare October 28, 2025 06:43

benzekrimaha marked this pull request as ready for review October 28, 2025 06:43

benzekrimaha force-pushed the improvement/CLDSRV-724-object-related-functional-tests branch from c56ac68 to 06547e0 Compare October 28, 2025 06:56

benzekrimaha force-pushed the improvement/CLDSRV-724-bucket-related-functional-tests branch from 92f36a8 to c1fb5b5 Compare October 28, 2025 06:58

ghost approved these changes Oct 28, 2025

View reviewed changes

DarkIsDude approved these changes Oct 28, 2025

View reviewed changes

benzekrimaha force-pushed the improvement/CLDSRV-724-object-related-functional-tests branch from 06547e0 to 1166011 Compare December 4, 2025 06:10

benzekrimaha force-pushed the improvement/CLDSRV-724-bucket-related-functional-tests branch 3 times, most recently from 0f033a6 to 3e2bdfc Compare December 4, 2025 06:33

benzekrimaha requested review from a team, SylvainSenechal and francoisferrand December 4, 2025 14:40

DarkIsDude approved these changes Dec 5, 2025

View reviewed changes

SylvainSenechal reviewed Dec 8, 2025

View reviewed changes

tests/functional/aws-node-sdk/test/bucket/deleteBucketPolicy.js Show resolved Hide resolved

SylvainSenechal reviewed Dec 8, 2025

View reviewed changes

tests/functional/aws-node-sdk/test/bucket/listingCornerCases.js Show resolved Hide resolved

SylvainSenechal reviewed Dec 8, 2025

View reviewed changes

SylvainSenechal approved these changes Dec 8, 2025

View reviewed changes

benzekrimaha force-pushed the improvement/CLDSRV-724-object-related-functional-tests branch from e3a5360 to fc23278 Compare December 23, 2025 15:40

get operation related bucket tests migration

4ce74c1

Issue: CLDSRV-724

benzekrimaha added 6 commits December 23, 2025 16:43

delete operation related bucket tests migration

f141dbf

Issue: CLDSRV-724

put operation related bucket tests migration

3722120

Issue: CLDSRV-724

other operations related bucket tests migration

a133997

Issue: CLDSRV-724

quota related bucket tests migration

5015974

Issue: CLDSRV-724

dependencies install

fa7eeb2

Issue: CLDSRV-724

fixups post reviews

84669aa

benzekrimaha force-pushed the improvement/CLDSRV-724-bucket-related-functional-tests branch from 79eb2ad to 84669aa Compare December 23, 2025 15:44

		// Use unique bucket name for each test to avoid conflicts
		testBucketName = `${bucketName}-${Date.now()}-${Math.random().toString(36).substr(2, 9)}`;

	// Create HTTP request (mimics AWS.HttpRequest with v2-like endpoint structure)
	// Create HTTP request

Improvement/cldsrv 724 bucket related functional tests #5988

Are you sure you want to change the base?

Improvement/cldsrv 724 bucket related functional tests #5988

Conversation

benzekrimaha commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Oct 27, 2025

Hello benzekrimaha,

Uh oh!

bert-e commented Oct 27, 2025

Waiting for approval

Uh oh!

codecov bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DarkIsDude left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benzekrimaha Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SylvainSenechal left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

benzekrimaha commented Oct 27, 2025 •

edited

Loading

codecov bot commented Oct 27, 2025 •

edited

Loading

benzekrimaha Dec 11, 2025 •

edited

Loading