fix(longevity_test): Set ignore 'raft topology connection close' error globally#10386
Merged
soyacz merged 1 commit intoscylladb:masterfrom Apr 10, 2025
Merged
Conversation
Contributor
|
@aleksbykov you added this inside so it's not exactly globally as the title says, it would work only if a case has validation for large collection enabled |
aleksbykov
force-pushed
the
fix-20950-error-message
branch
from
344c659 to
b751266
Compare
temichus
previously approved these changes
Apr 1, 2025
aleksbykov
force-pushed
the
fix-20950-error-message
branch
from
b751266 to
342ec62
Compare
temichus
previously approved these changes
Apr 6, 2025
soyacz
reviewed
Apr 7, 2025
aleksbykov
force-pushed
the
fix-20950-error-message
branch
2 times, most recently
from
1686dc1 to
dedc9ae
Compare
…globally Error: 'raft_topology - topology change coordinator fiber got error (connection is closed))' Could appeared in different moment when node/nodes are being restarted. As described in issue: scylladb/scylladb#20950 in comment: scylladb/scylladb#20950 (comment) the error message could appeared while we have race between raft and gossip. we can ignore this issue while issue will not be fixed on scylla side, gossip mode will be removed from scylla.
aleksbykov
force-pushed
the
fix-20950-error-message
branch
from
dedc9ae to
59c86ea
Compare
vponomaryov
approved these changes
Apr 10, 2025
Contributor
|
Looks like it broke one of our integration tests: |
aleksbykov
added a commit
to aleksbykov/scylla-cluster-tests
that referenced
this pull request
Apr 23, 2025
…rameter PR scylladb/scylla-cluster-tests/scylladb#10386 filter some expected raft error messages globally. But this change broke integration unit test. Issue scylladb#10676. This fix 2 things: - change function signature to run with passed sct config for unit tests or get sct running config - correctly filter error events. ignore_topology_change_coordinator_errors is context manager created as generator wrapped contextlib.contextmanager and DBEventsFilter are created using ExitStack as ContextManagers. To call this contextmanagers, was used `ignore_topology_change_coordinator_errors().__enter__()` call but once this call finished, all DBEventsFilters contextmangers executed theirs __exit__() method and thus all event filters marked as expired and appriate events are not filterd out. To avoid that, ExitStack object recreated and all __exit__ methods will be triggered after `yield`. This allow to run `ignore_topology_change_coordinator_errors` as context manager to wrap some code/functions/method or execute it globally withou events expiring Fixes scylladb#10676
2 tasks
aleksbykov
added a commit
to aleksbykov/scylla-cluster-tests
that referenced
this pull request
Apr 28, 2025
…rameter PR scylladb/scylla-cluster-tests/scylladb#10386 filter some expected raft error messages globally. But this change broke integration unit test. Issue scylladb#10676. Move DB event Filter from `ignore_topology_change_coordinator_errors` context manager to `enable_default_filters`. If the event will be filtered globally, then no need to filter it with cm. Fixes scylladb#10676
aleksbykov
added a commit
to aleksbykov/scylla-cluster-tests
that referenced
this pull request
Apr 28, 2025
…rameter PR scylladb/scylla-cluster-tests/scylladb#10386 filter some expected raft error messages globally. But this change broke integration unit test. Issue scylladb#10676. Move DB event Filter from `ignore_topology_change_coordinator_errors` context manager to `enable_default_filters`. If the event will be filtered globally, then no need to filter it with cm. Fixes scylladb#10676
aleksbykov
added a commit
to aleksbykov/scylla-cluster-tests
that referenced
this pull request
Apr 28, 2025
…rameter PR scylladb/scylla-cluster-tests/scylladb#10386 filter some expected raft error messages globally. But this change broke integration unit test. Issue scylladb#10676. Move DB event Filter from `ignore_topology_change_coordinator_errors` context manager to `enable_default_filters`. If the event will be filtered globally, then no need to filter it with cm. Fixes scylladb#10676
aleksbykov
added a commit
to aleksbykov/scylla-cluster-tests
that referenced
this pull request
Apr 28, 2025
…efault filters PR scylladb/scylla-cluster-tests/scylladb#10386 filter some expected raft error messages globally. But this change broke integration unit test. Issue scylladb#10676. Move DB event Filter from `ignore_topology_change_coordinator_errors` context manager to `enable_default_filters`. If the event will be filtered globally, then no need to filter it with cm. Fixes scylladb#10676
fruch
pushed a commit
that referenced
this pull request
Apr 29, 2025
…efault filters PR scylladb/scylla-cluster-tests/#10386 filter some expected raft error messages globally. But this change broke integration unit test. Issue #10676. Move DB event Filter from `ignore_topology_change_coordinator_errors` context manager to `enable_default_filters`. If the event will be filtered globally, then no need to filter it with cm. Fixes #10676
scylladbbot
pushed a commit
to scylladbbot/scylla-cluster-tests
that referenced
this pull request
Apr 29, 2025
…efault filters PR scylladb/scylla-cluster-tests/scylladb#10386 filter some expected raft error messages globally. But this change broke integration unit test. Issue scylladb#10676. Move DB event Filter from `ignore_topology_change_coordinator_errors` context manager to `enable_default_filters`. If the event will be filtered globally, then no need to filter it with cm. Fixes scylladb#10676 (cherry picked from commit 987afc1)
2 tasks
vponomaryov
pushed a commit
that referenced
this pull request
Apr 29, 2025
…efault filters PR scylladb/scylla-cluster-tests/#10386 filter some expected raft error messages globally. But this change broke integration unit test. Issue #10676. Move DB event Filter from `ignore_topology_change_coordinator_errors` context manager to `enable_default_filters`. If the event will be filtered globally, then no need to filter it with cm. Fixes #10676 (cherry picked from commit 987afc1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error: 'raft_topology - topology change coordinator fiber got error (connection is closed))' Could appeared in different moment when node/nodes are being restarted. As described in issue: scylladb/scylladb#20950 in comment: scylladb/scylladb#20950 (comment)
the error message could appeared while we have race between raft and gossip. we can ignore this issue while issue will not be fixed on scylla side, gossip mode will be removed from scylla.
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)