fix: allow alias renewal by re-submitting existing pair

[wa0x6e]

Summary

Re-submitting an existing (address, alias) pair was failing with a MySQL duplicate key error. This was problematic for bots and agents that use fixed addresses, as they couldn't renew or extend an alias once created.

Now the same pair can be re-submitted at any time (whether active or expired), which resets the created timestamp and effectively renews the alias. Uses ON DUPLICATE KEY UPDATE to handle this at the database level.

Changes

• 🔧 Changed INSERT to INSERT ... ON DUPLICATE KEY UPDATE in action() to refresh id, ipfs, and created on re-submission
• 🧪 Added integration tests for alias renewal and created timestamp bump
• 🧹 Fixed describe block name in unit test (writer/profile → writer/alias)

Test plan

• Verify alias unit tests pass (yarn test:unit)
• Verify integration tests pass (yarn test:integration)
• Manually test re-submitting an existing alias pair succeeds and updates the created timestamp

[Copilot]

Pull request overview

This PR aims to prevent duplicate alias pair creation by adding an explicit pre-insert check in the alias writer, returning a clear "alias already exists" rejection instead of bubbling up a raw MySQL primary-key error.

Changes:

• Added a duplicate (address, alias) existence check in src/writer/alias.ts verify() prior to insert.
• Added integration tests validating duplicate alias rejection and non-duplicate acceptance.
• Renamed a unit test describe block to correctly reference writer/alias.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
src/writer/alias.ts	Adds DB pre-check to reject duplicate alias pairs with a friendly error.
test/integration/helpers/alias.test.ts	Adds integration coverage for the new duplicate check in verify().
test/unit/writer/alias.test.ts	Fixes the unit test suite label from writer/profile to writer/alias.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[bonustrack]

Is this to enforce a single user have only 1 alias? If so it wont work, users might be logged on many devices we need multiple working alias for a single user to be possible.

[wa0x6e]

No, it’s to enforce alias is unique, and not associated to multiple adresses

[Copilot]

Pull request overview

Enables alias “renewal” by allowing re-submission of an existing (address, alias) pair without hitting a MySQL duplicate key error, updating the existing row instead.

Changes:

• Update alias writer DB write to use INSERT ... ON DUPLICATE KEY UPDATE so re-submitting the same pair refreshes stored fields (including created).
• Adjust alias self-alias validation to compare against message.address.
• Add/extend integration coverage for renewal behavior and fix a unit test describe label.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/writer/alias.ts	Writes aliases with ON DUPLICATE KEY UPDATE to support renewals; adjusts self-alias check to use message.address.
test/integration/helpers/alias.test.ts	Adds integration tests for renewal / created timestamp bump; changes DB seeding/cleanup strategy.
test/unit/writer/alias.test.ts	Renames the top-level describe block to writer/alias.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ChaituVR]

tAck