Added Notification timeout to widgets#4256
Merged
walterbender merged 1 commit intosugarlabs:masterfrom Jan 11, 2025
Merged
Conversation
Signed-off-by: Justin Charles <charlesjustin2124@gmail.com>
Member
|
Great thought but what if the user wants to read it for more than 3 seconds? |
Member
Author
|
@MostlyKIGuess I mean those statements are not too big for the users to take too much time to read them also 3 seconds is the alloted time as it builds on the functionality initiated in PR #4162 to maintain uniformity in the codebase as clearly mentioned in the pr. |
Member
Author
|
@walterbender please review this |
Member
Yeah makes sense, good work dude |
Member
Author
|
@MostlyKIGuess thanks mate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR resolves issue #4255 by introducing a notification timeout feature. With this enhancement, notifications automatically disappear after a set duration, eliminating the need for manual dismissal. This improvement ensures a smoother and more user-friendly experience.
Changes Made:
Added Notification Timeout Logic:
Introduced a timeout feature that automatically hides notifications after a specified duration of 3 seconds, building on the functionality initiated in PR #4162. This enhancement ensures notifications dismiss themselves seamlessly, eliminating the need for manual user intervention while maintaining the integrity of the codebase.
Screenshots/Video:
Untitled.video.-.Made.with.Clipchamp.3.mp4
Checklist: