-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style Change: Changed the styling of save dropdown list to icons #4401
base: master
Are you sure you want to change the base?
Conversation
@walterbender please review this |
@arjunjayan999 looks good. |
@arjunjayan999 Looks good but I like the original serial list style. I think a serial list style with the icons would be good. But you did a good job. |
@arjunjayan999 my vote is with the old version cause we have two things i.e artwork and block connection so this representation seems difficult to distuinguish between those for the child user |
I like the idea of it, but the icons need some work as per @omsuneri 's comment. |
@walterbender Any tips on where I can find icons? I tried finding them in well known libs, but didn't find any since these are a little niche file formats like mxml, ly, abc, etc. |
I think that you should ask for help on the Sugar channel. There are some great designers there, like Perrie. |
This PR includes changes to improve the save dropdown styling and update the save icons. I have added inline SVG directly into the HTML for now(It looks a little bloated and ugly in the HTML) from the artwork.js, couldn't find 4 icons (HTML, MXML, BlockArt-PNG, BlockArt-SVG), so got them from iconify and the tooltips for all icons.
Idea was suggested by @walterbender in a separate PR.
There is currently a bug i found where changing to advanced mode will make the save dropdown unusable until the page is refreshed and vice-versa for going from advanced to beginner. It was already there and should be sorted out in a separate PR, I think.
There was a minor bug in language dropdown not changing theme because of a previous PR, fixed it.
Styling and Dropdown Menu Enhancements:
css/activities.css
: Added new styles for#saveddropdown.active
and#saveddropdownbeg.active
to enhance the appearance and layout of active dropdown menus.css/themes.css
: Introduced new styles for dropdown content in dark mode, including background color and hover effects for links. [1] [2]HTML Structure Updates:
index.html
: Updated the structure of dropdown menus for saving options, replacingli
elements witha
elements and adding SVG icons with tooltips for better user experience.Demo
Screen.Recording.2025-02-13.184955.mp4