-
Notifications
You must be signed in to change notification settings - Fork 18
feat: acceleration and transport layer #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: acceleration and transport layer #348
Conversation
Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
…g and transport layer Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Note: this PR will be kept as a draft until #337 it merged, at which point this PR will be reabsed |
…cceleration_and_transport_layer Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…rt_layer Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
The concatenated PR was merged, so after solving the conflicts and some recent changes, I am opening this PR 🙏 |
…es implementation Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…rt_layer Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I left a few comments on readability/maintainability but that's all I think.
Is there a reason that x2(_gen2) is not covered?
@mojomex |
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…e used with shared containers Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…licts Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…rt_layer Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
@mojomex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like the two container_name params to be merged but otherwise LGTM
aip_common_sensor_launch/launch/nebula_node_container.launch.py
Outdated
Show resolved
Hide resolved
…alled pointcloud_container. The difference being whether they are loaded in the global namespace or created in a new container within the lidar namespace Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
@mojomex <arg name="use_shared_container" default="false"/>
<arg name="use_cuda_preprocessor" default="false"/> to <arg name="use_shared_container" default="true"/>
<arg name="use_cuda_preprocessor" default="true"/> in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xx1-cuda.webm
Works up until concat. I had to shoehorn the new autoware_universe into pilot-auto.xx1 so I could not test everything (at least autoware_tensorrt_plugins did not build successfully).
Since this is not this PR's fault, I'd say LGTM.
Description
This is part of the series of PR related to autowarefoundation/autoware_universe#9722
List of PRs:
Depending on your machine and how many nodes are in a container, the following branch may also be required:
https://github.com/knzo25/launch_ros/tree/fix/load_composable_node
There seems to be a but in ROS where if you send too many services at once some will be lost and
ros_launch
can not handle that.Related links
Parent Issue:
How was this PR tested?
The sensing/perception pipeline was tested until centerpoint for TIER IV's taxi using the logging simulator.
Notes for reviewers
The main branch that I used for development is
feat/cuda_acceleration_and_transport_layer2
.However, the changes were too big so I split the PRs. That being said, development, if any will still be on that branch (and then cherrypicked to the respective PRs), and the review changes will be cherrypicked into the development branch.
Interface changes
An additional topic is added to perform type negotiation:
Example:
input/pointcloud
->input/pointcloud
andinput/pointcloud/cuda
Effects on system behavior
Enabling this preprocessing in the launchers should provide a much reduced latency and cpu usage (at the cost of a higher GPU usage)