feat(autoware_traffic_light_classifier): add underexposure detection#2700
Conversation
…2672) * refactor(autoware_traffic_light_classifier): split utils and add test (autowarefoundation#10633) * first commit Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp> * split data convert Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp> * chore Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp> * style(pre-commit): autofix * move function Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp> * add const Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp> * add const Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp> --------- Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> * feat(traffic_light_classifier): add under exposure detection (autowarefoundation#11818) * add under exposure detection Signed-off-by: Masaki Baba <masaki.baba.2@tier4.jp> * update parameter Signed-off-by: Masaki Baba <masaki.baba.2@tier4.jp> * add test for under exposure Signed-off-by: Masaki Baba <masaki.baba.2@tier4.jp> * style(pre-commit): autofix * change diagnostics to distinguish over and under exposure Signed-off-by: Masaki Baba <masaki.baba.2@tier4.jp> * change parameter Signed-off-by: Masaki Baba <masaki.baba.2@tier4.jp> * style(pre-commit): autofix * change default value Signed-off-by: Masaki Baba <masaki.baba.2@tier4.jp> * fix required Signed-off-by: Masaki Baba <masaki.baba.2@tier4.jp> --------- Signed-off-by: Masaki Baba <masaki.baba.2@tier4.jp> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> --------- Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp> Signed-off-by: Masaki Baba <masaki.baba.2@tier4.jp> Co-authored-by: Masato Saeki <78376491+MasatoSaeki@users.noreply.github.com> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
|
Please take care about config file in jetson launcher and sync version. |
mojomex
left a comment
There was a problem hiding this comment.
I just noticed I got assigned as reviewer due to what looks like an unnecessary and unrelated change to pointcloud preprocessor, please check 🙇
There was a problem hiding this comment.
Is there a reason this file was touched in this PR? Looks to me like it's only style changes, so please revert to keep this PR clean.
There was a problem hiding this comment.
@mojomex sorry to bother you ;( . it seems the pre-commit fixed the source code format when I run the CI. the change is not intentional. I will revert the commit keep only the core changes.
02c1bad to
f5e8e8a
Compare
|



This PR will cherry-pick (backport) #2672
commits:
need to merge with https://github.com/tier4/edge_auto_jetson_launch.x2/pull/41