Skip to content

Comments

feat(autoware_traffic_light_classifier): add underexposure detection#2700

Merged
a-maumau merged 1 commit intofeat/addon_streampetr_integfrom
mau/port/traffic_light_classifier/underexposure_detection
Feb 20, 2026
Merged

feat(autoware_traffic_light_classifier): add underexposure detection#2700
a-maumau merged 1 commit intofeat/addon_streampetr_integfrom
mau/port/traffic_light_classifier/underexposure_detection

Conversation

@a-maumau
Copy link

@a-maumau a-maumau commented Feb 19, 2026

This PR will cherry-pick (backport) #2672

commits:

need to merge with https://github.com/tier4/edge_auto_jetson_launch.x2/pull/41

…2672)

* refactor(autoware_traffic_light_classifier): split utils and add test (autowarefoundation#10633)

* first commit

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* split data convert

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* chore

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* style(pre-commit): autofix

* move function

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* add const

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* add const

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

---------

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* feat(traffic_light_classifier): add under exposure detection (autowarefoundation#11818)

* add under exposure detection

Signed-off-by: Masaki Baba <masaki.baba.2@tier4.jp>

* update parameter

Signed-off-by: Masaki Baba <masaki.baba.2@tier4.jp>

* add test for under exposure

Signed-off-by: Masaki Baba <masaki.baba.2@tier4.jp>

* style(pre-commit): autofix

* change diagnostics to distinguish over and under exposure

Signed-off-by: Masaki Baba <masaki.baba.2@tier4.jp>

* change parameter

Signed-off-by: Masaki Baba <masaki.baba.2@tier4.jp>

* style(pre-commit): autofix

* change default value

Signed-off-by: Masaki Baba <masaki.baba.2@tier4.jp>

* fix required

Signed-off-by: Masaki Baba <masaki.baba.2@tier4.jp>

---------

Signed-off-by: Masaki Baba <masaki.baba.2@tier4.jp>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

---------

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: Masaki Baba <masaki.baba.2@tier4.jp>
Co-authored-by: Masato Saeki <78376491+MasatoSaeki@users.noreply.github.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Copy link

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi
Copy link

YoshiRi commented Feb 19, 2026

Please take care about config file in jetson launcher and sync version.

Copy link

@mojomex mojomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed I got assigned as reviewer due to what looks like an unnecessary and unrelated change to pointcloud preprocessor, please check 🙇

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this file was touched in this PR? Looks to me like it's only style changes, so please revert to keep this PR clean.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mojomex sorry to bother you ;( . it seems the pre-commit fixed the source code format when I run the CI. the change is not intentional. I will revert the commit keep only the core changes.

@a-maumau a-maumau removed the run:build-and-test-differential After beta/v0.41 label Feb 20, 2026
@a-maumau a-maumau force-pushed the mau/port/traffic_light_classifier/underexposure_detection branch from 02c1bad to f5e8e8a Compare February 20, 2026 04:10
@sonarqubecloud
Copy link

@a-maumau a-maumau merged commit ec8805d into feat/addon_streampetr_integ Feb 20, 2026
41 of 46 checks passed
@a-maumau a-maumau deleted the mau/port/traffic_light_classifier/underexposure_detection branch February 20, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants