Skip to content

[TRNT-4376] Align DB dependencies#712

Merged
antgamdia merged 4 commits into
mainfrom
TRNT-4358-fix-ci
May 13, 2026
Merged

[TRNT-4376] Align DB dependencies#712
antgamdia merged 4 commits into
mainfrom
TRNT-4358-fix-ci

Conversation

@antgamdia

@antgamdia antgamdia commented May 11, 2026

Copy link
Copy Markdown
Contributor

Description

I noticed some tests are failing (example); this PR is to try to discover and fix the issue causing it.

This PR is aligning the versions we use in development and in CI to the ones we use in the Helm Chart (manually for now, though). Using latest was causing some issues in out test cases.

Besides, it extracts some additional versions to env dependencies, for maintainability.

Fixes # TRNT-4376

How was this tested?

CI

Before the fix, it fails (example); after the fix, it works (example).

Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
@coveralls

coveralls commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 93.823% (+63.8%) from 30.07% — TRNT-4358-fix-ci into main

Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
@antgamdia antgamdia added the ci label May 11, 2026
@antgamdia antgamdia marked this pull request as ready for review May 11, 2026 14:18
@antgamdia antgamdia requested a review from vicenteqa May 11, 2026 14:18
@antgamdia antgamdia changed the title Extract versions to env vars [TRNT-4376] Align DB dependencies May 11, 2026
@antgamdia antgamdia requested a review from nelsonkopliku May 12, 2026 10:42

@vicenteqa vicenteqa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I know this development is about aligning, but I see that we're still pinning the postgres version in two different places, perhaps we need to think in some way to have a single source of truth.

@antgamdia

antgamdia commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

I see that we're still pinning the postgres version in two different places, perhaps we need to think in some way to have a single source of truth.

Yes, absolutely. Besides, this is also applicable to Web :( I'll be creating a PR shortly. See trento-project/web#4290.

https://github.com/trento-project/web/blob/main/docker-compose.yaml#L62
https://github.com/trento-project/web/blob/main/.github/workflows/ci.yaml#L35

We could do it in a shared repo, set up a GHA to, once it changes, perform some replacements in every affected repo? But at least, the bare minimum is to ensure, even manually, that we are using the same version in the same repo 😅

Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
@antgamdia antgamdia merged commit 2cea3a1 into main May 13, 2026
28 checks passed
@antgamdia antgamdia deleted the TRNT-4358-fix-ci branch May 13, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants