[FPSAN] Fix TMEM emulation correctness#10542
Merged
Merged
Conversation
This was referenced Jun 8, 2026
pawelszczerbuk
approved these changes
Jun 9, 2026
This was referenced Jun 10, 2026
jeffniu-openai
force-pushed
the
jeffniu/fpsan-unified-imma
branch
2 times, most recently
from
ec6c757 to
cd7ba80
Compare
jeffniu-openai
added a commit
that referenced
this pull request
Jun 11, 2026
Rebase PR #10542 onto the updated stack.
jeffniu-openai
force-pushed
the
jeffniu/fpsan-tmem-correctness
branch
from
09d6ca5 to
5a6c843
Compare
jeffniu-openai
force-pushed
the
jeffniu/fpsan-unified-imma
branch
from
cd7ba80 to
58edc77
Compare
jeffniu-openai
requested review from
antiagainst,
lezcano and
zhanglx13
as code owners
jeffniu-openai
force-pushed
the
jeffniu/fpsan-tmem-correctness
branch
from
5a6c843 to
4b569dc
Compare
jeffniu-openai
force-pushed
the
jeffniu/fpsan-unified-imma
branch
from
58edc77 to
d5b4894
Compare
jeffniu-openai
force-pushed
the
jeffniu/fpsan-tmem-correctness
branch
from
4b569dc to
1cbc878
Compare
jeffniu-openai
force-pushed
the
jeffniu/fpsan-unified-imma
branch
from
d5b4894 to
3231015
Compare
jeffniu-openai
force-pushed
the
jeffniu/fpsan-tmem-correctness
branch
from
1cbc878 to
72efe81
Compare
jeffniu-openai
added a commit
that referenced
this pull request
Jun 12, 2026
PR description written by Codex Load shared MMA operands directly into their result layouts and reuse existing scale shadows, avoiding redundant layout conversions and scale snapshots, and also load accumulator directly into its MMA layout. ## Stack Merge bottom-up: - [x] #10472 - [x] #10473 - [ ] #10527 (this PR) - [ ] #10532 - [ ] #10533 - [ ] #10542 - [ ] #10548 - [ ] #10561 - [ ] #10559
jeffniu-openai
force-pushed
the
jeffniu/fpsan-tmem-correctness
branch
from
72efe81 to
992c380
Compare
jeffniu-openai
force-pushed
the
jeffniu/fpsan-unified-imma
branch
from
3231015 to
6e6e181
Compare
jeffniu-openai
force-pushed
the
jeffniu/fpsan-unified-imma
branch
from
6e6e181 to
471d978
Compare
jeffniu-openai
force-pushed
the
jeffniu/fpsan-tmem-correctness
branch
from
992c380 to
6104d1b
Compare
jeffniu-openai
added a commit
that referenced
this pull request
Jun 12, 2026
PR description written by Codex Optimize i8 decomposition by reordering the dots and eagerly combining into the accumulator-on-the-fly to minimize register pressure, and include a basic subtiling heuristic determined experimentally ## Stack Merge bottom-up: - [x] #10472 - [x] #10473 - [x] #10527 - [x] #10532 - [ ] #10533 (this PR) - [ ] #10542 - [ ] #10548 - [ ] #10561 - [ ] #10559
jeffniu-openai
force-pushed
the
jeffniu/fpsan-tmem-correctness
branch
from
6104d1b to
68bf15f
Compare
jeffniu-openai
added a commit
that referenced
this pull request
Jun 12, 2026
PR description written by Codex Remove redundant payload sign clears before masked multiplies so NVPTX cannot fold them to `abs.f32`, which quiets signaling NaNs. Add a reduced one-warp regression that fails bitwise on PR #10542’s base and passes with the fix. ## Stack Merge bottom-up: - [x] #10472 - [x] #10473 - [x] #10527 - [x] #10532 - [x] #10533 - [x] #10542 - [ ] #10548 (this PR) - [ ] #10561 - [ ] #10559
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description written by Codex
Fix FPSAN TMEM emulation for initialized scratch synchronization, predicated stores, reduction loads, and scale-copy reinterpret views.
Stack
Merge bottom-up: