Allow ihr to be non-multiples of 6#336
Merged
grantfirl merged 1 commit intoufs-community:ufs/devfrom Jan 5, 2026
Merged
Conversation
Author
DavidHuber-NOAA
requested review from
Qingfu-Liu,
dustinswales,
grantfirl and
rhaesung
as code owners
Author
|
All UFS_Utils regression and unit tests passed successfully on Ursa without changes to baselines. |
7 tasks
Author
|
@ClaraDraper-NOAA Do you think this approach makes sense? Would you mind reviewing this PR and/or recommending an appropriate reviewer for this? |
|
Thanks @DavidHuber-NOAA this will first need to go through the UFSWM system, before UFS_UTILS. I'll try to get to that today. |
21 tasks
This was referenced Dec 29, 2025
ClaraDraper-NOAA
approved these changes
Dec 29, 2025
Collaborator
There was a problem hiding this comment.
I am not at all familiar with the sea ice analysis, so can't comment on that. This PR does solve the issue of enabling sfcsub to find the most recent sea ice analysis, starting with a time that is not a multiple of 6. Thanks @DavidHuber-NOAA!
BrianCurtis-NOAA
approved these changes
Dec 29, 2025
rhaesung
approved these changes
Dec 30, 2025
Qingfu-Liu
approved these changes
Dec 30, 2025
grantfirl
approved these changes
Jan 5, 2026
|
Testing for ufs-community/ufs-weather-model#3030 has completed successfully; this PR can be merged. |
This was referenced Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes:
The seaice file for the 06Z GFS cycle is updated When running IAU surface updates for the GFS, input hours can be multiples of 3. This results in an error in sfcsub.F when the input data time is on a previous day (as described in NOAA-EMC/global-workflow#4364). Additionally, if the forecast cycle is not on 0, 6, 12, or 18 (which may happen at some point), global_cycle will need to perform updates on hours that are not a multiple of 6. This PR allows global_cycle to be run at any hour.
Tests Conducted:
Tested this in the global-workflow for a C96 ATM-only 3DVar case on cycle 2021122106 where the seaice input grib file was valid at 2021122000. This change allowed the surface analysis to run successfully and for future cycles to run successfully as well.
All UFS_Utils unit and regression tests passed.
Documentation:
N/A
Issue (optional):
Refs NOAA-EMC/global-workflow#4364
Contributors (optional):
@jiaruidong2017 @RussTreadon-NOAA @ClaraDraper-NOAA