fix lsrro circular import #1700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-a-a
commented
Nov 24, 2025
Comment on lines
+1831
to
+1833
| has_NaCl_solubility_limit=True, | ||
| has_calculated_concentration_polarization=has_CP, | ||
| has_calculated_ro_pressure_drop=True, |
Contributor
Author
There was a problem hiding this comment.
this really should be updated to match what was specified in run_lsrro_case
adam-a-a
commented
Nov 24, 2025
Comment on lines
+1844
to
+1846
| set_default_bounds_on_module_dimensions=True, | ||
| A_value=A_value, | ||
| permeate_quality_limit=permeate_quality_limit, |
Contributor
Author
There was a problem hiding this comment.
Should also make sure this aligns with what user provided up front
adam-a-a
commented
Nov 24, 2025
Contributor
|
@adam-a-a do you want to memorialize the additional changes you wanted to make in this PR in an issue if we want to merge this now? |
kurbansitterley
approved these changes
Dec 4, 2025
Contributor
Author
|
@kurbansitterley thanks for the reminder. The additional changes desired are tied to #1644 which in turn leads to other suggested changes stemming from #1629 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves:
Summary/Motivation:
Fix circular import bettween lsrro flowsheet and multi_sweep.
Changes proposed in this PR:
-Fix circular import bettween lsrro flowsheet and multi_sweep.
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: