Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiktor/Migrate to RustCrypto #26

Merged
merged 25 commits into from
Apr 5, 2024
Merged

Wiktor/Migrate to RustCrypto #26

merged 25 commits into from
Apr 5, 2024

Conversation

wiktor-k
Copy link
Owner

This is a continuation of #16 to see how far we can go :)

@wiktor-k wiktor-k mentioned this pull request Mar 26, 2024
@wiktor-k wiktor-k force-pushed the wiktor/migrate-to-rustcrypto branch 2 times, most recently from 3722e88 to 1d16554 Compare March 26, 2024 16:26
@wiktor-k wiktor-k force-pushed the wiktor/migrate-to-rustcrypto branch 3 times, most recently from 745df63 to e7411c9 Compare April 2, 2024 20:09
src/proto/message.rs Outdated Show resolved Hide resolved
@baloo baloo force-pushed the wiktor/migrate-to-rustcrypto branch 2 times, most recently from 24676f5 to aa63dda Compare April 3, 2024 06:01
@baloo baloo mentioned this pull request Apr 3, 2024
@baloo baloo force-pushed the wiktor/migrate-to-rustcrypto branch 2 times, most recently from c1580a7 to 5a110e7 Compare April 4, 2024 05:45
@wiktor-k wiktor-k force-pushed the wiktor/migrate-to-rustcrypto branch from 5a110e7 to bc63738 Compare April 4, 2024 07:01
@wiktor-k
Copy link
Owner Author

wiktor-k commented Apr 4, 2024

Folks, a quick summary of what's going on:

Thanks to @jcspencer's work in #30 (that I've cherry-picked here) and a bit of message capturing code I've recorded a test session (tests/sign-and-verify.sh) and put all these requests in tests/messages (it occurred to me now that I've captured only requests, ugh, time to capture more!).

Then, I added a "roundtrip tests" thingy that takes all messages, decodes them and re-encodes and compares bytes. (The encoding part, once again, thanks to @jcspencer 🙇 ).

I think this can severely simplify the recent tests that we have. First of all putting test artifacts in tests/messages automatically tests for decode/encode cycle so it's not necessary to do it twice. Second it's not necessary to hex-encode that... I hope you don't mind @baloo 😅

And the tests now can only check if the message that's decoded has correct stuff in appropriate places which should make them a bit more readable.

@jcspencer jcspencer mentioned this pull request Apr 4, 2024
@wiktor-k wiktor-k marked this pull request as ready for review April 4, 2024 16:57
Copy link
Collaborator

@baloo baloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit shipit

@wiktor-k
Copy link
Owner Author

wiktor-k commented Apr 5, 2024

Okay folks... I'm going to clean up the commits a bit (too many WIPs from me 😅 ) and merge it. Once in main it's easier to stabilize and check what's still missing.

Thanks for your help and patience! 👋

baloo and others added 10 commits April 5, 2024 08:45
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
wiktor-k and others added 15 commits April 5, 2024 08:45
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
@wiktor-k wiktor-k force-pushed the wiktor/migrate-to-rustcrypto branch from e2b879a to a1c0beb Compare April 5, 2024 06:45
@wiktor-k wiktor-k enabled auto-merge April 5, 2024 06:46
@wiktor-k wiktor-k merged commit d0b92fd into main Apr 5, 2024
15 checks passed
@wiktor-k wiktor-k deleted the wiktor/migrate-to-rustcrypto branch April 5, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants