-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wiktor/Migrate to RustCrypto #26
Conversation
3722e88
to
1d16554
Compare
745df63
to
e7411c9
Compare
24676f5
to
aa63dda
Compare
c1580a7
to
5a110e7
Compare
5a110e7
to
bc63738
Compare
Folks, a quick summary of what's going on: Thanks to @jcspencer's work in #30 (that I've cherry-picked here) and a bit of message capturing code I've recorded a test session ( Then, I added a "roundtrip tests" thingy that takes all messages, decodes them and re-encodes and compares bytes. (The encoding part, once again, thanks to @jcspencer 🙇 ). I think this can severely simplify the recent tests that we have. First of all putting test artifacts in And the tests now can only check if the message that's decoded has correct stuff in appropriate places which should make them a bit more readable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shipit shipit
Okay folks... I'm going to clean up the commits a bit (too many Thanks for your help and patience! 👋 |
Signed-off-by: Arthur Gautier <[email protected]> Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]> Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: James Spencer <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
e2b879a
to
a1c0beb
Compare
This is a continuation of #16 to see how far we can go :)