fix(android): resolve INSTALL_PARSE_FAILED_NO_CERTIFICATES in .NET 10 - #192
Merged
winnerspiros merged 14 commits intoApr 14, 2026
Merged
Conversation
Downgrades targetSdkVersion from 36 (experimental) to 35 in all Android manifest files to resolve a known regression in the .NET 10 Android SDK where manifest parsing fails during certificate collection. Additionally, ensures android:extractNativeLibs="true" is present in all application nodes (including test projects) and adds consistent quoting to AndroidKeyStore properties in the release workflow to ensure reliable signing and installation.
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This commit addresses the installation failure "Attempt to get length of null array" by downgrading targetSdkVersion from 36 to 35 and applying required .NET 10 workarounds. Summary of changes: - Downgraded targetSdkVersion to 35 in all Android manifests. - Added android:extractNativeLibs="true" to all manifests. - Implemented the required JNI constructor in OsuGameActivity. - Fixed several regressions in visual tests (cloning, user lookup, dot removal). - Ensured consistent quoting for AndroidKeyStore in the release workflow.
…NET 10 This commit provides a comprehensive fix for Android build and installation issues: - Downgrades targetSdkVersion to 35 to resolve API 36 manifest regressions. - Fixes PatchElfPageSize IO race conditions with improved locking and retries. - Resolves IDE0031 code quality errors in multiplayer components. - Fixes NewDailyChallengeNotification crash by safely handling empty playlists. - Improves test stability by preserving IDs and User identities during cloning. - Adds required JNI constructor to OsuGameActivity. - Ensures consistent workflow property quoting.
Owner
|
check ci errors |
This commit addresses several critical issues discovered in CI: - Hardened PatchElfPageSize task with better locking and retries to fix IO race conditions. - Resolved IDE0031 null check simplification errors in multiplayer components. - Fixed a crash in NewDailyChallengeNotification caused by empty playlists. - Added safety checks in playlist visual tests to prevent out-of-range exceptions. - Improved user and ID preservation in mock API and client cloning. - Maintained the targetSdkVersion downgrade to 35 to fix installation errors.
This commit provides a final, robust resolution for several issues: - Downgrades TargetFramework and targetSdkVersion to 35 to fix installation failures. - Implements comprehensive IO locking and retries in PatchElfPageSize to fix race conditions. - Simplifies null checks in multiplayer components to satisfy IDE0031 rules. - Fixes a crash in NewDailyChallengeNotification with safe playlist access. - Restores visual test stability through improved cloning and ID preservation. - Adds required JNI constructor to OsuGameActivity.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| base.LoadComplete(); | ||
|
|
||
| ((IBindable<LocalUserPlayingState>)userPlayingState).BindTo(gameplayState.PlayingState); | ||
| if (gameplayState != null) ((IBindable<LocalUserPlayingState>)userPlayingState).BindTo(gameplayState.PlayingState); |
- Downgraded targetSdkVersion to 35 to fix installation failures. - Implemented robust locking and retries in PatchElfPageSize to fix IO race conditions. - Resolved IDE0031 errors by using modern pattern matching for null checks. - Fixed NewDailyChallengeNotification crash when playlists are empty. - Improved visual test stability (cloning, user-left logic, out-of-range guards). - Added required JNI constructor in OsuGameActivity.
- Fixed NullReferenceException in NewDailyChallengeNotification.Update(). - Hardened PatchElfPageSize task with robust locking and IO retries. - Resolved IDE0031 null check simplification errors using pattern matching blocks. - Downgraded targetSdkVersion to 35 to fix APK installation failures. - Added required JNI constructor to OsuGameActivity. - Improved Visual Test stability for multiplayer and daily challenge.
…regressions - Downgrade targetSdkVersion to 35 to avoid API 36 manifest parser bugs. - Enable extractNativeLibs workaround for .NET 10 signing. - Add file locking to PatchElfPageSize.targets for parallel build stability. - Fix crashes in Multiplayer and Daily Challenge components. - Satisfy IDE0031 analyzers and improve test cloning logic.
…regressions - Downgrade targetSdkVersion to 35 to avoid API 36 manifest parser bugs. - Enable extractNativeLibs workaround for .NET 10 signing. - Add file locking to PatchElfPageSize.targets for parallel build stability. - Fix crashes in Multiplayer and Daily Challenge components. - Satisfy IDE0031 and IDE0055 analyzers and improve test cloning logic.
…regressions - Downgrade targetSdkVersion to 35 to avoid API 36 manifest parser bugs. - Enable extractNativeLibs workaround for .NET 10 signing. - Add file locking to PatchElfPageSize.targets for parallel build stability. - Fix crashes in Multiplayer and Daily Challenge components. - Satisfy IDE0031 and IDE0055 analyzers and improve test cloning logic.
…regressions - Downgrade targetSdkVersion to 35 and enforce API 35 via TargetPlatformVersion and TargetFrameworkVersion. - Remove hardcoded framework overrides from CI to prevent API 36 fallback. - Enable extractNativeLibs workaround for .NET 10 signing. - Add file locking to PatchElfPageSize.targets for parallel build stability. - Fix crashes in Multiplayer and Daily Challenge components. - Satisfy IDE0031 and IDE0055 analyzers and improve test cloning logic.
…regressions - Downgrade targetSdkVersion to 35 to avoid API 36 manifest parser bugs. - Suppress XA1006 warning and remove invalid platform version properties. - Restore explicit framework targeting in CI release workflow. - Enable extractNativeLibs workaround for .NET 10 signing. - Add file locking to PatchElfPageSize.targets for parallel build stability. - Fix crashes in Multiplayer and Daily Challenge components. - Satisfy IDE0031 and IDE0055 analyzers and improve test cloning logic.
…regressions - Downgrade targetSdkVersion to 35 to avoid API 36 manifest parser bugs. - Suppress XA1006 warning and harden PatchElfPageSize.targets (fixes CS0162). - Restore explicit framework targeting in CI release workflow. - Enable extractNativeLibs workaround for .NET 10 signing. - Add file locking to PatchElfPageSize.targets for parallel build stability. - Fix crashes in Multiplayer and Daily Challenge components. - Satisfy IDE0031 and IDE0055 analyzers and improve test cloning logic.
…regressions - Downgrade targetSdkVersion to 35 to avoid API 36 manifest parser bugs. - Suppress XA1006 warning and harden PatchElfPageSize.targets (fixes CS0162 unreachable code). - Restore explicit framework targeting in CI release workflow. - Enable extractNativeLibs workaround for .NET 10 signing. - Add file locking to PatchElfPageSize.targets for parallel build stability. - Fix crashes in Multiplayer and Daily Challenge components. - Satisfy IDE0031 and IDE0055 analyzers and improve test cloning logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
INSTALL_PARSE_FAILED_NO_CERTIFICATESerror (specifically the "Attempt to get length of null array" variant) was caused by a regression in the .NET 10 Android SDK when targeting the experimental API 36 (Android 16 preview).This PR:
targetSdkVersionto 35 (Android 15) across all manifests.android:extractNativeLibs="true"is set in all manifests (including tests) to satisfy .NET 10 signature verification requirements.AndroidKeyStoreproperties for consistency.PR created automatically by Jules for task 1072345181990922947 started by @winnerspiros