Skip to content

Conversation

@Ecarrion
Copy link
Contributor

Closes: #8551

Why

This PR takes care of updating the variation count of the main product after generating variations. This is needed to properly reflect changes on the main product screen and on the product list.

Demo

demo-updated-products.mov

Testing Steps

  • Start the generate all variation process
  • After generating the variations go back to the main product screen
  • See that the variation count matches the previous variation count + the new generated variations count.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Ecarrion Ecarrion added the feature: variation list Related to the variations list for variable products. label Jan 11, 2023
@Ecarrion Ecarrion added this to the 11.9 milestone Jan 11, 2023
@peril-woocommerce
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8612-f0bfd44 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@rachelmcr rachelmcr self-assigned this Jan 12, 2023
Copy link
Contributor

@rachelmcr rachelmcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@Ecarrion Ecarrion merged commit b14c1c7 into trunk Jan 12, 2023
@Ecarrion Ecarrion deleted the issue/8551-update-product branch January 12, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: variation list Related to the variations list for variable products.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Variations: Make sure the original product reflects the variation changes

4 participants