Skip to content

Variations: Update product variation count after generating variations #8612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Variations: Update product variation count after generating variations #8612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions WooCommerce/Classes/ViewRelated/Products/Variations/ProductVariationsViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,6 +697,13 @@ private extension ProductVariationsViewController {
let notice = Notice(title: Localization.variationsCreatedTitle)
noticePresenter.enqueue(notice: notice)
}

/// Updates the current product with the up-to-date list of variations IDs.
/// This is needed in order to reflect variations count changes back to this and to other screens.
///
private func updateProductVariationCount() {
self.product = product.copy(variations: resultsController.fetchedObjects.map { $0.productVariationID })
}
}

// MARK: - Placeholders
Expand Down Expand Up @@ -786,6 +793,7 @@ extension ProductVariationsViewController: SyncingCoordinatorDelegate {
case .finished(let variationsCreated):
self?.dismissBlockingIndicator()
if variationsCreated {
self?.updateProductVariationCount()
self?.presentVariationsCreatedNotice()
} else {
self?.presentNoGenerationNotice()
Expand Down