Address some deprecation after dropping iOS 13 #19512
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokagio
force-pushed
the
mokagio/more-ios-14-deprecations
branch
from
089ffab to
3069cb7
Compare
Contributor
You can test the changes in WordPress from this Pull Request by:
|
mokagio
force-pushed
the
mokagio/remove-ios-13-widgets
branch
from
46b53ec to
fc4d3b8
Compare
mokagio
force-pushed
the
mokagio/more-ios-14-deprecations
branch
from
3069cb7 to
ac0bbd6
Compare
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
mokagio
force-pushed
the
mokagio/remove-ios-13-widgets
branch
from
0956955 to
d6392db
Compare
The compiler says: ``` warning build: 'allVisible' was deprecated in iOS 14.0: renamed to 'UISplitViewController.DisplayMode.oneBesideSecondary' ```
The compiler said: ``` warning build: 'primaryHidden' was deprecated in iOS 14.0: renamed to 'UISplitViewController.DisplayMode.secondaryOnly' ```
I did my best to find a valid replacement and left a note to hopefully help improving upon my attempt.
mokagio
force-pushed
the
mokagio/more-ios-14-deprecations
branch
from
941736d to
637ef3e
Compare
With iOS 14 as the minimum deployment target, they all return `true`.
It always returns true, since the codebase now supports iOS 14+
mokagio
force-pushed
the
mokagio/more-ios-14-deprecations
branch
from
637ef3e to
0fbf95e
Compare
Contributor
Author
|
This is now redundant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I plan to split this PR in one that address all of the straightforward removals and one that makes the remaining. This way, we can merge the first ASAP and use the latter as a place where to discuss the best changes.