Update user details view #23777

crazytonyli · 2024-11-06T07:40:21Z

Note

This PR is built on top of #23768.

Before	After

Regression Notes

Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)

PR submission checklist:

I have completed the Regression Notes.
I have considered adding unit tests for my changes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

wpmobilebot · 2024-11-06T07:50:06Z

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23777-c8778ba
	Version	25.4.2
	Bundle ID	org.wordpress.alpha
	Commit	`c8778ba`
	App Center Build	WPiOS - One-Offs #11009

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot · 2024-11-06T07:50:27Z

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23777-c8778ba
	Version	25.4.2
	Bundle ID	com.jetpack.alpha
	Commit	`c8778ba`
	App Center Build	jetpack-installable-builds #10049

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

dangermattic · 2024-11-06T22:41:47Z

	2 Warnings
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	This PR is assigned to the milestone 25.6. This milestone is due in less than 4 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

kean · 2024-11-07T15:15:36Z

The web-based login crashes on iPad when I invoke it from the "Application Passwords" screen:

kean · 2024-11-07T16:31:16Z

Modules/Sources/WordPressUI/Views/Users/Components/UserProfileImage.swift

-            }
-        )
+        if let url {
+            AsyncImage(


Please replace this with AvatarView. AsyncImage should basically never be used.

AvatarView or AsyncImageView are currently unavailable in WordPressUI as they are part of the app target. But UserProfile* don't belong to WordPressUI as it's designed for reusable components. It should be small and should compile fast as, in the long term, more modules will depend on it.

I suggest the following changes:

Create a WordPressMedia framework (or similar name) with ImageDownloader – other media-related stuff could go there later too.

Move AvatarView and AsyncImageView to either WordPressUI or WordPressMedia

(If you want to keep the previews) Create a separate module for user management.

If we keep adding everything to WordPressUI, it will eventually stop working well for Xcode Previews as these tend to become unusable with 10K+ lines in a module. The only long-term option if we want to facilitate Xcode Previews is to create feature-based modules (aka app micro modules). Since we are now fully in the SPM world, it should be feasible, so it might be a good time to start.

Sorry, I forgot to reply to your original comment about AsyncImage.

Shall I just move the new user management code to the app target for now? So that the AvatarView and ImageDownloader stuff (I don't think we need it for this particular feature) will be available. /cc @jkmassel

Let's address it separately. I'm going to add the approval as is.

kean · 2024-11-07T16:31:47Z

Modules/Sources/WordPressUI/Views/Users/UserProvider.swift


-    let dummyDataUrl = URL(string: "https://my.api.mockaroo.com/users.json?key=067c9730")!
+    enum Scenario {
+        case inifitLoading


typo – "infinite"

kean · 2024-11-07T16:32:23Z

Modules/Sources/WordPressUI/Views/Users/Views/UserDetailsView.swift

+
+            if viewModel.currentUserCanModifyUsers {
+                Section(Strings.accountManagementSectionTitle) {
+                    NavigationLink {


Let's show these as modal screens.

In follow-up PRs, I'll use an alert for the "set new password" feature and a modal/sheet for deleting users.

crazytonyli · 2024-11-07T21:11:14Z

@kean I couldn't reproduce that crash, neither on an iPad nor on an iPad simulator. Can you produce it consistently?

I wonder if that has something to do with the new window (instead of an existing window from a view controller) used here:

WordPress-iOS/WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsViewController+SectionHelpers.swift

Line 222 in 2d76a25

let success = try await authenticator.authentication(site: url, from: nil)

Note: when passing nil, a UIWindow instance will be created internally to present the authentication web view.

crazytonyli · 2024-11-07T21:12:39Z

⬆️ Rebased without any code changes.

kean · 2024-11-13T13:11:36Z

Modules/Sources/WordPressUI/Views/Users/Components/UserProfileImage.swift

-            }
-        )
+        if let url {
+            AsyncImage(


Let's address it separately. I'm going to add the approval as is.

crazytonyli added the Self-hosted label Nov 6, 2024

crazytonyli added this to the 25.6 milestone Nov 6, 2024

crazytonyli requested review from jkmassel and kean November 6, 2024 07:40

crazytonyli mentioned this pull request Nov 6, 2024

Self-hosted site user management #23768

Merged

14 tasks

crazytonyli force-pushed the fix/self-hosted-site-users branch from d876f7d to 5fbfd0c Compare November 7, 2024 08:47

kean reviewed Nov 7, 2024

View reviewed changes

Base automatically changed from add/self-hosted-site-users-list-view to trunk November 7, 2024 20:53

crazytonyli added 17 commits November 8, 2024 10:11

Remove an unused API

89c5a55

Change argument from CGSize to CGFloat

bccddb7

Make UserProfileImage display circular avatar

eca4f44

Display the largest avatar (96x96px)

3d528a7

Add previews for loading and error state

7764c6f

Set users list background color

8ea5dc6

Add UserListViewModel.onAppear to avoid repeatedly fetching users

f661694

Use the name REST API field for "Display Name"

126f765

Update user details view

bf06766

Show 'Users' entry in the WordPress app

f6c6f7c

Update an list search API

904a8f2

Replace deprecated sizeCategory with dynamicTypeSize

40bed61

Update users searchable strings

86f7c54

Add private(set) to some View Model properties

82273ca

Remove an unnecessary os version check

b0c1443

Update localized string keys

7f9b87c

Rename UserDetailView to UserDetailsView

2caa0ae

crazytonyli force-pushed the fix/self-hosted-site-users branch from 5fbfd0c to 2caa0ae Compare November 7, 2024 21:12

Fix a typo

c8778ba

crazytonyli mentioned this pull request Nov 10, 2024

Present an alert for setting a new password #23790

Merged

14 tasks

crazytonyli requested a review from kean November 12, 2024 21:45

kean approved these changes Nov 13, 2024

View reviewed changes

crazytonyli added this pull request to the merge queue Nov 13, 2024

Merged via the queue into trunk with commit 6d67d85 Nov 13, 2024
24 checks passed

crazytonyli deleted the fix/self-hosted-site-users branch November 13, 2024 22:08

crazytonyli mentioned this pull request Apr 10, 2025

Update wordpress-rs to the latest release #24437

Merged

14 tasks

Update user details view #23777

Update user details view #23777

Uh oh!

Conversation

crazytonyli commented Nov 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Notes

Uh oh!

wpmobilebot commented Nov 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Nov 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dangermattic commented Nov 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kean commented Nov 7, 2024

Uh oh!

kean Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

crazytonyli Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

kean Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

kean Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

kean Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

crazytonyli Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

crazytonyli commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crazytonyli commented Nov 7, 2024

Uh oh!

kean Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

crazytonyli commented Nov 6, 2024 •

edited

Loading

wpmobilebot commented Nov 6, 2024 •

edited

Loading

wpmobilebot commented Nov 6, 2024 •

edited

Loading

dangermattic commented Nov 6, 2024 •

edited

Loading

crazytonyli commented Nov 7, 2024 •

edited

Loading