Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry Framework #5094

Closed
wants to merge 6 commits into from
Closed

Conversation

Starlight220
Copy link
Member

Initial work for the telemetry API suggested in @Oblarg 's design doc.

@Oblarg
Copy link
Contributor

Oblarg commented Feb 13, 2023

Great to see work started on this!

Remember that in the most-recent version of the doc, dashboard widget config would occur in its own topic via json message content, rather than in the topic metadata.

@Starlight220
Copy link
Member Author

Starlight220 commented Feb 13, 2023

We've discussed multiple changes that didn't make it into the doc, and we should probably discuss further. Is this the place?

UPDATE: per Oblarg/docs#5 (comment), widget preference is included in object metadata.

@Starlight220
Copy link
Member Author

Starlight220 commented Mar 3, 2023

After some second thinking, I'm not sure whether completely breaking everything (Sendable is depended on by nearly everything) is the best idea.

I think that a lot of the current problems with Sendable are more with the way it's used by the LiveWindow, SmartDashboard, and Shuffleboard APIs than with Sendable itself (which is a rather simple API), so fixing it incrementally with minimal breakage should be possible.

@Starlight220
Copy link
Member Author

Discussion at #5177.

@calcmogul calcmogul added the component: telemetry High level telemetry functionality label Dec 2, 2023
@PeterJohnson
Copy link
Member

Superseded by #6453.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: telemetry High level telemetry functionality
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants