Fix SequentialCommandGroup.isFinished is false after command finishes
#7901
Conversation
- end() sets current command index to -1 - isFinished() checks if the current command index equals the command list size - fixes this by also checking in isFinished if the current command index is -1
|
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
github-actions
bot
added
the
component: command-based
- isFinished is false after command is finished See allwpilib#7901 [here](wpilibsuite/allwpilib#7901)
|
This would cause isFinished to return true before the command started, too -- which is worse behavior than the current, imo. Calling isFinished only has defined behavior between initialize and end, and is intended only for internal use by the scheduler (or composition implementations). See #6411 and others. |
|
yes f/e. Threw this together quick on GH. Easy enough to track at with a var or something else trivial. I get if it's intended for internal use, but it is public, and its behavior is inconsistent with other command impls. Caught this by doing unit tests for some command groups and noticed parallel and others isFinished worked but sequential did not. |
|
I can switch to isScheduled for unit tests in most cases. I have similar opinions to OP #6411 that it should be in docs that isFinished is for internal scheduler and composition use and behavior may not be what's expected by name or consistent with other commands. |
It's inconsistent because calling |
end()sets current command index to -1isFinished()checks if the current command index equals the command list sizeisFinished()if the current command index is -1