Skip to content

[examples] Add compilable code snippets #7909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions shared/examplecheck.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,24 @@ task checkExamples(type: Task) {
}
}

task checkSnippets(type: Task) {
doLast {
def parsedJson = new groovy.json.JsonSlurper().parseText(snippetsFile.text)
fileCheck(parsedJson, snippetsDirectory)
parsedJson.each {
assert it.name != null
assert it.description != null
assert it.tags != null
assert it.tags.findAll { !tagList.contains(it) }.empty
assert it.foldername != null
assert it.gradlebase != null
if (it.gradlebase == 'java') {
assert it.mainclass != null
}
}
}
}

task checkCommands(type: Task) {
doLast {
def parsedJson = new groovy.json.JsonSlurper().parseText(commandFile.text)
Expand All @@ -127,3 +145,4 @@ task checkCommands(type: Task) {
check.dependsOn checkTemplates
check.dependsOn checkExamples
check.dependsOn checkCommands
check.dependsOn checkSnippets
14 changes: 14 additions & 0 deletions wpilibcExamples/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ include(SubDirList)

subdir_list(TEMPLATES ${CMAKE_SOURCE_DIR}/wpilibcExamples/src/main/cpp/templates)
subdir_list(EXAMPLES ${CMAKE_SOURCE_DIR}/wpilibcExamples/src/main/cpp/examples)
subdir_list(SNIPPETS ${CMAKE_SOURCE_DIR}/wpilibcExamples/src/main/cpp/snippets)

add_custom_target(wpilibcExamples)
add_custom_target(wpilibcExamples_test)
Expand Down Expand Up @@ -63,3 +64,16 @@ foreach(template ${TEMPLATES})
target_link_libraries(${template} wpilibc wpilibNewCommands romiVendordep xrpVendordep)
add_dependencies(wpilibcExamples ${template})
endforeach()

foreach(snippet ${SNIPPETS})
file(
GLOB_RECURSE sources
src/main/cpp/snippets/${snippet}/cpp/*.cpp
src/main/cpp/snippets/${snippet}/c/*.c
)
add_executable(snippet${snippet} ${sources})
wpilib_target_warnings(${snippet})
target_include_directories(snippet${snippet} PUBLIC src/main/cpp/snippets/${snippet}/include)
target_link_libraries(snippet${snippet} wpilibc wpilibNewCommands romiVendordep xrpVendordep)
add_dependencies(wpilibcExamples snippet${snippet})
endforeach()
123 changes: 109 additions & 14 deletions wpilibcExamples/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -14,25 +14,43 @@ apply from: "${rootDir}/shared/googletest.gradle"

ext.examplesMap = [:]
ext.templatesMap = [:]
ext.snippetsMap = [:]

File examplesTree = file("$projectDir/src/main/cpp/examples")
examplesTree.list(new FilenameFilter() {
ext {
templateDirectory = new File("$projectDir/src/main/cpp/templates/")
templateFile = new File("$projectDir/src/main/cpp/templates/templates.json")
exampleDirectory = new File("$projectDir/src/main/cpp/examples/")
exampleFile = new File("$projectDir/src/main/cpp/examples/examples.json")
commandDirectory = new File("$projectDir/src/main/cpp/commands/")
commandFile = new File("$projectDir/src/main/cpp/commands/commands.json")
snippetsDirectory = new File("$projectDir/src/main/cpp/snippets/")
snippetsFile = new File("$projectDir/src/main/cpp/snippets/snippets.json")
}

exampleDirectory.list(new FilenameFilter() {
@Override
public boolean accept(File current, String name) {
return new File(current, name).isDirectory();
}
}).each {
examplesMap.put(it, [])
}
File templatesTree = file("$projectDir/src/main/cpp/templates")
templatesTree.list(new FilenameFilter() {
templateDirectory.list(new FilenameFilter() {
@Override
public boolean accept(File current, String name) {
return new File(current, name).isDirectory();
}
}).each {
templatesMap.put(it, [])
}
snippetsDirectory.list(new FilenameFilter() {
@Override
public boolean accept(File current, String name) {
return new File(current, name).isDirectory();
}
}).each {
snippetsMap.put(it, [])
}

nativeUtils.platformConfigs.named(nativeUtils.wpi.platforms.windowsx64).configure {
linker.args.remove('/DEBUG:FULL')
Expand All @@ -41,7 +59,7 @@ nativeUtils.platformConfigs.named(nativeUtils.wpi.platforms.windowsx64).configur
}

ext {
sharedCvConfigs = examplesMap + templatesMap + [commands: []]
sharedCvConfigs = examplesMap + templatesMap + snippetsMap.collectEntries { key, value -> ['snippets' + key, value] } + [commands: []]
staticCvConfigs = [:]
useJava = false
useCpp = true
Expand Down Expand Up @@ -171,6 +189,57 @@ model {
}
}
}
snippetsMap.each { key, value ->
"snippets${key}"(NativeExecutableSpec) {
targetBuildTypes 'debug'
binaries.all { binary ->
lib project: ':wpilibNewCommands', library: 'wpilibNewCommands', linkage: 'shared'
lib project: ':romiVendordep', library: 'romiVendordep', linkage: 'shared'
lib project: ':xrpVendordep', library: 'xrpVendordep', linkage: 'shared'
lib project: ':wpilibc', library: 'wpilibc', linkage: 'shared'
lib project: ':apriltag', library: 'apriltag', linkage: 'shared'
lib project: ':wpimath', library: 'wpimath', linkage: 'shared'
project(':ntcore').addNtcoreDependency(binary, 'shared')
lib project: ':cscore', library: 'cscore', linkage: 'shared'
project(':hal').addHalDependency(binary, 'shared')
lib project: ':cameraserver', library: 'cameraserver', linkage: 'shared'
lib project: ':wpinet', library: 'wpinet', linkage: 'shared'
lib project: ':wpiutil', library: 'wpiutil', linkage: 'shared'
if (binary.targetPlatform.name == nativeUtils.wpi.platforms.roborio) {
nativeUtils.useRequiredLibrary(binary, 'ni_link_libraries', 'ni_runtime_libraries')
}
if (binary.targetPlatform.name == getCurrentArch()) {
simModules.each {
lib project: ":simulation:$it", library: it, linkage: 'shared'
}
}
}
sources {
cpp {
source {
srcDirs 'src/main/cpp/snippets/' + "${key}" + "/cpp"
include '**/*.cpp'
}
exportedHeaders {
srcDirs 'src/main/cpp/snippets/' + "${key}" + "/include"
include '**/*.h'
}
}
}
sources {
c {
source {
srcDirs 'src/main/cpp/snippets/' + "${key}" + "/c"
include '**/*.c'
}
exportedHeaders {
srcDirs 'src/main/cpp/snippets/' + "${key}" + "/include"
include '**/*.h'
}
}
}
}
}
}
testSuites {
examplesMap.each { key, value ->
Expand Down Expand Up @@ -207,6 +276,41 @@ model {
}
}
}
testSuites {
snippetsMap.each { key, value ->
def testFolder = new File("${rootDir}/wpilibcExamples/src/test/cpp/snippets/${key}")
if (testFolder.exists()) {
"snippets${key}Test"(GoogleTestTestSuiteSpec) {
for (NativeComponentSpec c : $.components) {
if (c.name == key) {
testing c
break
}
}
sources {
cpp {
source {
srcDirs "src/test/cpp/examples/${key}/cpp"
include '**/*.cpp'
}
exportedHeaders {
srcDirs "src/test/cpp/examples/${key}/include"
}
}
c {
source {
srcDirs "src/test/cpp/examples/${key}/c"
include '**/*.c'
}
exportedHeaders {
srcDirs "src/test/cpp/examples/${key}/include"
}
}
}
}
}
}
}
binaries {
withType(GoogleTestTestSuiteBinarySpec) {
lib project: ':wpilibNewCommands', library: 'wpilibNewCommands', linkage: 'shared'
Expand Down Expand Up @@ -253,15 +357,6 @@ model {
}
}

ext {
templateDirectory = new File("$projectDir/src/main/cpp/templates/")
templateFile = new File("$projectDir/src/main/cpp/templates/templates.json")
exampleDirectory = new File("$projectDir/src/main/cpp/examples/")
exampleFile = new File("$projectDir/src/main/cpp/examples/examples.json")
commandDirectory = new File("$projectDir/src/main/cpp/commands/")
commandFile = new File("$projectDir/src/main/cpp/commands/commands.json")
}

model {
// Create run tasks for all examples.
tasks {
Expand Down
69 changes: 69 additions & 0 deletions wpilibcExamples/src/main/cpp/snippets/Encoder/cpp/Robot.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
// Copyright (c) FIRST and other WPILib contributors.
// Open Source Software; you can modify and/or share it under the terms of
// the WPILib BSD license file in the root directory of this project.

#include <numbers>

#include <frc/Encoder.h>
#include <frc/TimedRobot.h>
#include <frc/smartdashboard/SmartDashboard.h>
#include <wpi/deprecated.h>

/**
* Encoder snippets for frc-docs.
* https://docs.wpilib.org/en/stable/docs/software/hardware-apis/sensors/encoders-software.html
*/
WPI_IGNORE_DEPRECATED
class Robot : public frc::TimedRobot {
public:
Robot() {
// Configures the encoder to return a distance of 4 for every 256 pulses
// Also changes the units of getRate
m_encoder.SetDistancePerPulse(4.0 / 256.0);
// Configures the encoder to consider itself stopped after .1 seconds
m_encoder.SetMaxPeriod(0.1_s);
// Configures the encoder to consider itself stopped when its rate is below
// 10
m_encoder.SetMinRate(10);
// Reverses the direction of the encoder
m_encoder.SetReverseDirection(true);
// Configures an encoder to average its period measurement over 5 samples
// Can be between 1 and 127 samples
m_encoder.SetSamplesToAverage(5);
}

void TeleopPeriodic() override {
// Gets the distance traveled
m_encoder.GetDistance();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to show return values here? (I know we'll need to disable unused variable warnings).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't currently show return values in frc-docs encoder page.

I think the question would be whether you declare the variable inline, which shows the type and would be more useful to new programmers, but isn't what you'd want to do in a periodic function in the snippet, or just set a variable.

I'd tend to keep it exactly as it is in the docs to make it faster to get everything converted to snippets and find/fix breakage, and do improvements later.


// Gets the current rate of the encoder
m_encoder.GetRate();

// Gets whether the encoder is stopped
m_encoder.GetStopped();

// Gets the last direction in which the encoder moved
m_encoder.GetDirection();

// Gets the current period of the encoder
m_encoder.GetPeriod();

// Resets the encoder to read a distance of zero
m_encoder.Reset();
}

private:
// Initializes an encoder on DIO pins 0 and 1
// Defaults to 4X decoding and non-inverted
frc::Encoder m_encoder{0, 1};

// Initializes an encoder on DIO pins 0 and 1
// 2X encoding and non-inverted
frc::Encoder m_encoder2x{0, 1, false, frc::Encoder::EncodingType::k2X};
};

#ifndef RUNNING_FRC_TESTS
int main() {
return frc::StartRobot<Robot>();
}
#endif
12 changes: 12 additions & 0 deletions wpilibcExamples/src/main/cpp/snippets/snippets.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
[
{
"name": "Encoder",
"description": "Snippets of Encoder class usage for frc-docs.",
"tags": [
"Hardware",
"Encoder"
],
"foldername": "Encoder",
"gradlebase": "cpp"
}
]
43 changes: 43 additions & 0 deletions wpilibjExamples/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ ext {
exampleFile = new File("$projectDir/src/main/java/edu/wpi/first/wpilibj/examples/examples.json")
commandDirectory = new File("$projectDir/src/main/java/edu/wpi/first/wpilibj/commands/")
commandFile = new File("$projectDir/src/main/java/edu/wpi/first/wpilibj/commands/commands.json")
snippetsDirectory = new File("$projectDir/src/main/java/edu/wpi/first/wpilibj/snippets/")
snippetsFile = new File("$projectDir/src/main/java/edu/wpi/first/wpilibj/snippets/snippets.json")
}

apply plugin: 'cpp'
Expand Down Expand Up @@ -203,6 +205,47 @@ model {
test.dependsOn(testTask)
}
}
new groovy.json.JsonSlurper().parseText(snippetsFile.text).each { entry ->
project.tasks.create("runSnippet${entry.foldername}", JavaExec) { run ->
run.group "run snippets"
run.mainClass = "edu.wpi.first.wpilibj.snippets." + entry.foldername + "." + entry.mainclass
run.classpath = sourceSets.main.runtimeClasspath
run.dependsOn it.tasks.install
run.systemProperty 'java.library.path', filePath
doFirst { doFirstTask(run) }

if (org.gradle.internal.os.OperatingSystem.current().isMacOsX()) {
run.jvmArgs = ['-XstartOnFirstThread']
}
}
project.tasks.create("testSnippet${entry.foldername}", Test) { testTask ->
testTask.group "verification"
testTask.useJUnitPlatform()
testTask.filter {
includeTestsMatching("edu.wpi.first.wpilibj.snippets.${entry.foldername}.*")
setFailOnNoMatchingTests(false)
}
test.filter {
excludeTestsMatching("edu.wpi.first.wpilibj.snippets.${entry.foldername}.*")
setFailOnNoMatchingTests(false)
}
testTask.testClassesDirs = sourceSets.test.output.classesDirs
testTask.classpath = sourceSets.test.runtimeClasspath
testTask.dependsOn it.tasks.install

testTask.systemProperty 'junit.jupiter.extensions.autodetection.enabled', 'true'
testTask.testLogging {
events "failed"
exceptionFormat "full"
}
testTask.systemProperty 'java.library.path', filePath

if (project.hasProperty('onlylinuxathena') || project.hasProperty('onlylinuxarm32') || project.hasProperty('onlylinuxarm64') || project.hasProperty('onlywindowsarm64')) {
testTask.enabled = false
}
test.dependsOn(testTask)
}
}

found = true
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
// Copyright (c) FIRST and other WPILib contributors.
// Open Source Software; you can modify and/or share it under the terms of
// the WPILib BSD license file in the root directory of this project.

package edu.wpi.first.wpilibj.snippets.encoder;

import edu.wpi.first.wpilibj.RobotBase;

/**
* Do NOT add any static variables to this class, or any initialization at all. Unless you know what
* you are doing, do not modify this file except to change the parameter class to the startRobot
* call.
*/
public final class Main {
private Main() {}

/**
* Main initialization function. Do not perform any initialization here.
*
* <p>If you change your main robot class, change the parameter type.
*/
public static void main(String... args) {
RobotBase.startRobot(Robot::new);
}
}
Loading
Loading