-
Notifications
You must be signed in to change notification settings - Fork 671
[upstream_utils] Upgrade to Sleipnir 0.3.2 #8323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2027
Are you sure you want to change the base?
[upstream_utils] Upgrade to Sleipnir 0.3.2 #8323
Conversation
|
Blocked on:
|
822d86c to
e618bd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the -Xmx8g change intended to be part of this PR?
|
Yes, though I could try a build without it. 🤷 |
ba88512 to
788a725
Compare
|
Turns out Doxygen 1.15.0 has way more bugs than 1.12.0 (e.g., warnings in source code it thought was comments), which I was able to reproduce locally. Sleipnir's CI uses Doxygen 1.9.8 (Ubuntu 24.04's default version, which doesn't have the issue. allwpilib needs 1.12.0 to fix some modern C++ parsing bugs though, so I made this PR skip parsing the problematic Sleipnir headers with 1.12.0. |
788a725 to
d89f3c7
Compare
|
I just hit the JVM OOM with 4 GB of heap, so looks like 8 GB is needed after all. |
d89f3c7 to
1da8c97
Compare
4e78961 to
6aad90c
Compare
KangarooKoala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened to the Java cart pole benchmark?
|
Per the top comment on this PR, it's in #8236. We can't do a Java version of the benchmark unless there's a Java API to benchmark. |
|
Windows debug CI is failing with a Gradle JVM OOM error. The JVM heap is set to 16 GB (the VM's max RAM), so idk how we can fix it. |
6aad90c to
67157a9
Compare
Also add Sleipnir cart-pole benchmark from wpilibsuite#8323.
67157a9 to
52c0de2
Compare
Also add Sleipnir cart-pole benchmark from wpilibsuite#8323.
Also add Sleipnir cart-pole benchmark from #8323.
5c7aaa7 to
4b362d2
Compare
4b362d2 to
d9dfd1b
Compare
76c89e8 to
e85a1a7
Compare
db40905 to
d9bb29a
Compare
d9bb29a to
4ca1b2d
Compare
69398dd to
bd435c4
Compare
bd435c4 to
58e3048
Compare
Also includes a C++ benchmark, which has a Java counterpart in #8236.