[ntcore] Add ability to announce mDNS for server #8373
+128
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: ntcore
Comment on lines
188
to
+191
| if not isSimulation: | ||
| inst.startServer("/home/systemcore/networktables.ini") | ||
| inst.startServer("/home/systemcore/networktables.json", "", "robot") | ||
| else: | ||
| inst.startServer() | ||
| inst.startServer("networktables.json", "", "robot") |
Contributor
There was a problem hiding this comment.
Is changing the extension intentional?
Member
There was a problem hiding this comment.
Yes, it should have always been json.
PeterJohnson
approved these changes
Nov 21, 2025
PeterJohnson
changed the title
Member
|
Looks like some Python tests need fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use this as a new way of resolving addresses.