[datalog] Add java entry map #8377
Open
+241
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaDizzy
force-pushed
the
java-datalog-entry-map
branch
from
b297fca to
4f478ff
Compare
DeltaDizzy
force-pushed
the
java-datalog-entry-map
branch
from
4f478ff to
fc0fb6e
Compare
Member
|
The C++ DataLogReader class does not have these functions, only DataLogReaderThread does. DataLogReaderThread reads the entire file (in the background) in order to build the map, and the user can separately check (or have a signal callback) to find out when reading is complete. The current approach in this PR has a major flaw in that it doesn't read the entire file for the user. A user would need to iterate over the entire file first (to build the map) before the added functions would work. This ordering dependency is not obvious in the API. Also, in Java, you might not want to construct entries for the entire file, so this background scan should probably not do that, and manually decode only the start and finish records? |
datalog/src/main/java/org/wpilib/datalog/DataLogReaderThread.java
Outdated
Show resolved
Hide resolved
datalog/src/main/java/org/wpilib/datalog/DataLogReaderThread.java
Outdated
Show resolved
Hide resolved
DeltaDizzy
force-pushed
the
java-datalog-entry-map
branch
from
94aeaeb to
192a0f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C++
DataLogReaderclasses allow the user to get the name, type, metadata, etc. of any entry in a log given only its entry id using an internal map. The java library does not expose this functionality, so this is a proof of concept at one way this could be added. There are some very obvious warts but I want to get feedback if I am even barking up the right tree to begin with.Closes #8126
TODO: