Skip to content

Add check for string size in ConvertToC function #8446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gnorkus wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Add check for string size in ConvertToC function #8446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cscore/src/main/native/cpp/c_util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@
namespace cs {

inline void ConvertToC(struct WPI_String* output, std::string_view str) {
char* write = WPI_AllocateString(output, str.size());
std::memcpy(write, str.data(), str.size());
size_t n = str.size();
char* write = WPI_AllocateString(output, n);
if (n>0)
Copy link
Member

@calcmogul calcmogul Dec 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our style guide requires curly braces on control flow statements.

std::memcpy(write, str.data(), n);
}

} // namespace cs
Expand Down
Loading