Fix memory allocation in ConvertToC function #8447
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There needs to be a check for zero length strings so that memmove does not get called to copy a zero length string and avoid a build break. C++ 20 can detect errors like this and stops the build.
calcmogul
reviewed
Dec 4, 2025
| *out_len = in.size(); | ||
| size_t n; | ||
| char* out = static_cast<char*>(wpi::safe_malloc(n + 1)); | ||
| if (n>0) |
Member
There was a problem hiding this comment.
Our style guide requires curly braces on control flow statements.
Gold856
requested changes
Dec 4, 2025
| std::memmove(out, in.data(), in.size()); // NOLINT | ||
| out[in.size()] = '\0'; | ||
| *out_len = in.size(); | ||
| size_t n; |
Contributor
Can you please elaborate on this? We upgraded to C++20 three years ago and haven't noticed issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There needs to be a check for zero length strings so that memmove does not get called to copy a zero length string and avoid a build break. C++ 20 can detect errors like this and stops the build.