[javac] Add @MaxLength annotation for limiting lengths of string parameters#8493
Open
SamCarlberg wants to merge 4 commits intowpilibsuite:2027from
Open
[javac] Add @MaxLength annotation for limiting lengths of string parameters#8493SamCarlberg wants to merge 4 commits intowpilibsuite:2027from
@MaxLength annotation for limiting lengths of string parameters#8493SamCarlberg wants to merge 4 commits intowpilibsuite:2027from
Conversation
Useful for eg OpModes, where names have a maximum length
Name, description, and group name lengths are all validated Current limits are 32 chars for the name, 12 for the group name, and 64 for the description
Member
|
Seeing as these don't result in runtime errors (we'll just truncate), should these be warnings instead of errors? |
Member
Author
|
Warnings would clutter the IDE logs and be ignored. My goal with the compiler plugins is to catch code that's obviously incorrect and code that won't function as the user expects; opmode string length checks fall into the second category, since the code that you write won't match what you see in practice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful for eg OpModes, where names have a maximum length
Also includes validations for values in opmode annotations like
@Autonomous(name = "..."); name, group, and description all have maximum allowable lengths