[glass] Fix server mode #8508
Open
[glass] Fix server mode #8508
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: glass
ThadHouse
approved these changes
Dec 24, 2025
PeterJohnson
approved these changes
Dec 24, 2025
virtuald
reviewed
Dec 24, 2025
| wpi::nt::StartDSClient(m_inst, m_port); | ||
| } | ||
| } else if (m_mode == 3) { | ||
| } else if (m_mode == 2) { |
Member
There was a problem hiding this comment.
probably all of these numbers should be using NT_NET_MODE_*?
Member
Author
There was a problem hiding this comment.
They correspond with the indices of the values in the enum chooser array here, so I don't think using the NT mode enum is the right choice. Totally agree it'd be better if these weren't magic numbers, but I'm not sure how to link the selection result back to the input choices with the current api shape.
Perhaps EnumSetting should take an array of pairs of (display string, value)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.