Move NI DS specific joystick classes to their own subfolder #8513
+568
−1,658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will let us hide it from intellisense for the FTC Alpha
github-actions
bot
added
component: wpilibj
Contributor
KangarooKoala
left a comment
KangarooKoala
left a comment
There was a problem hiding this comment.
Looks like there were some minor button binding swaps.
|
|
||
| // Deploy the intake with the X button | ||
| m_driverController.X().OnTrue(m_intake.IntakeCommand()); | ||
| m_driverController.EastFace().OnTrue(m_intake.IntakeCommand()); |
Contributor
There was a problem hiding this comment.
Suggested change
| m_driverController.EastFace().OnTrue(m_intake.IntakeCommand()); | |
| m_driverController.WestFace().OnTrue(m_intake.IntakeCommand()); |
|
|
||
| // Deploy the intake with the X button | ||
| m_driverController.x().onTrue(m_intake.intakeCommand()); | ||
| m_driverController.eastFace().onTrue(m_intake.intakeCommand()); |
Contributor
There was a problem hiding this comment.
Suggested change
| m_driverController.eastFace().onTrue(m_intake.intakeCommand()); | |
| m_driverController.westFace().onTrue(m_intake.intakeCommand()); |
| m_driverController | ||
| .a() | ||
| .and(m_driverController.rightBumper()) | ||
| .eastFace() |
Contributor
There was a problem hiding this comment.
Suggested change
| .eastFace() | |
| .southFace() |
Matches the previous bindings and C++.
| m_driverController | ||
| .b() | ||
| .and(m_driverController.rightBumper()) | ||
| .southFace() |
Contributor
There was a problem hiding this comment.
Suggested change
| .southFace() | |
| .eastFace() |
| m_driverController | ||
| .a() | ||
| .and(m_driverController.leftBumper()) | ||
| .eastFace() |
Contributor
There was a problem hiding this comment.
Suggested change
| .eastFace() | |
| .southFace() |
| m_driverController | ||
| .b() | ||
| .and(m_driverController.leftBumper()) | ||
| .southFace() |
Contributor
There was a problem hiding this comment.
Suggested change
| .southFace() | |
| .eastFace() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let us hide it from intellisense for the FTC Alpha