Skip to content

Build Javadoc with JDK 26 for dark theme support#8842

Open
katzuv wants to merge 1 commit into
wpilibsuite:mainfrom
katzuv:javadoc-dark-theme
Open

Build Javadoc with JDK 26 for dark theme support#8842
katzuv wants to merge 1 commit into
wpilibsuite:mainfrom
katzuv:javadoc-dark-theme

Conversation

@katzuv
Copy link
Copy Markdown
Contributor

@katzuv katzuv commented May 1, 2026

image

This is done to include openjdk/jdk@0755477 (relevant PR openjdk/jdk#26185).

Copilot AI review requested due to automatic review settings May 1, 2026 23:47
@katzuv katzuv requested a review from a team as a code owner May 1, 2026 23:47
@katzuv katzuv changed the title Build Javadoc with JDK 26 for dark theme support Build with JDK 26 for dark theme support in Javadoc May 1, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions Gradle workflow to use JDK 26 (Temurin) during CI builds, primarily intended to pick up newer Javadoc output (dark theme support) from upstream OpenJDK changes.

Changes:

  • Bump actions/setup-java version selector from Java 25 to Java 26 in the host build job.
  • Bump Java version to 26 for the documentation (Javadoc) build job.
  • Bump Java version to 26 for the combine/publish pipeline job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/gradle.yml
@katzuv katzuv force-pushed the javadoc-dark-theme branch from 54bc9eb to 9d1a56f Compare May 1, 2026 23:53
@katzuv katzuv changed the title Build with JDK 26 for dark theme support in Javadoc Build Javadoc with JDK 26 for dark theme support May 2, 2026
@katzuv katzuv force-pushed the javadoc-dark-theme branch from 9d1a56f to 347fd2c Compare May 2, 2026 08:08
@katzuv
Copy link
Copy Markdown
Contributor Author

katzuv commented May 2, 2026

Copy link
Copy Markdown
Contributor

@Project516 Project516 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeterJohnson PeterJohnson changed the base branch from 2027 to main May 3, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2027 2027 target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants