[epilogue] Improve support for robot base classes in epilogue#8886
Open
SamCarlberg wants to merge 2 commits into
Open
[epilogue] Improve support for robot base classes in epilogue#8886SamCarlberg wants to merge 2 commits into
SamCarlberg wants to merge 2 commits into
Conversation
Generate an `update` method for any logged Robot class Generate a `bind` method for logged TimedRobot subclasses
Contributor
|
Should the |
Member
Author
TimedRobot and OpModeRobot don't have the same signatures; OpModeRobot doesn't accept a phase offset like TimedRobot does. RobotBase doesn't have an addPeriodic function, so bind wouldn't make sense there |
PeterJohnson
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate an
updatemethod for any logged Robot class, not just TimedRobotContinue to generate a
bindmethod for TimedRobot subclassesAlso removes unnecessary import statements for generated loggers, since they're using fully-qualified names in the generated Epilogue class now.