Skip to content

feat(filesr): support vdi_revert - #124

Open
klmp200 wants to merge 2 commits into
3.2.12-8.3-develfrom
vdi_revert
Open

feat(filesr): support vdi_revert#124
klmp200 wants to merge 2 commits into
3.2.12-8.3-develfrom
vdi_revert

Conversation

@klmp200

@klmp200 klmp200 commented Feb 27, 2026

Copy link
Copy Markdown

Introduce VDI revert functionality on FileSR with journalised roll-back.

This includes cbt support

Stacked PR review

  1. feat(filesr): support vdi_revert #124 <- Current
  2. feat(lvmsr): support vdi_revert on lvm #128
  3. feat(linstor): implement vdi_revert on linstor #132

Integration tests PR: xcp-ng/xcp-ng-tests#627

Revert schematic
image

@klmp200
klmp200 force-pushed the vdi_revert branch 4 times, most recently from 723011a to f666bf6 Compare March 5, 2026 16:24
@klmp200
klmp200 force-pushed the vdi_revert branch 2 times, most recently from 657cff3 to 39a4908 Compare March 9, 2026 08:47
Comment thread drivers/FileSR.py Outdated
Comment thread drivers/FileSR.py Outdated
@klmp200
klmp200 marked this pull request as ready for review March 9, 2026 12:20
@klmp200 klmp200 changed the title FileSR vdi_revert feat(filesr): support vdi_revert Mar 9, 2026
@klmp200
klmp200 requested review from a team and AnthoineB March 9, 2026 12:22
@klmp200
klmp200 marked this pull request as draft March 9, 2026 12:44
Comment thread drivers/FileSR.py Outdated
@klmp200
klmp200 requested a review from imperosol March 11, 2026 13:20
@klmp200
klmp200 changed the base branch from dtt-3.2.12-8.3-qcow2-cowutil to 3.2.12-8.3-cowutil-qcow2 April 27, 2026 11:50
@klmp200
klmp200 force-pushed the vdi_revert branch 2 times, most recently from 9fe38b9 to 4244614 Compare April 27, 2026 13:15
@klmp200
klmp200 force-pushed the vdi_revert branch 2 times, most recently from 3a71e41 to d9a0e98 Compare July 3, 2026 14:47
Comment thread drivers/FileSR.py Outdated
Comment thread drivers/FileSR.py Outdated
@klmp200
klmp200 requested a review from a team July 16, 2026 08:42
Comment thread drivers/FileSR.py
@Kuruyia
Kuruyia requested a review from a team July 16, 2026 09:00
Comment thread drivers/FileSR.py
Comment thread drivers/FileSR.py

@Lankou66 Lankou66 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Support vdi_revert from xapi
* Enable VDI_REVERT capability on FileSR
* Implement vdi revert on File based SRs
* Support CBT on vdi revert
* Support vdi_revert rollback with journal in case of catastrophic failure
* Fix ZFSSR tests
* Add `tap_pause` context manager to base `VDI` object
* add generic journaling capabilities
* Fix permission on nfs-on-slave plugin

Signed-off-by: Antoine Bartuccio <antoine.bartuccio@vates.tech>
Remove workaround used to convert OpaqueRef received on `vdi_revert` commands
as receiving this ref is now the expected behavior xapi-project/xen-api#7170

Signed-off-by: Antoine Bartuccio <antoine.bartuccio@vates.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants