[waiting for sm feature] Create tests for vdi_revert on file based SRs - #627
[waiting for sm feature] Create tests for vdi_revert on file based SRs#627klmp200 wants to merge 2 commits into
Conversation
4636534 to
90acbcb
Compare
Signed-off-by: Antoine Bartuccio <antoine.bartuccio@vates.tech>
Signed-off-by: Antoine Bartuccio <antoine.bartuccio@vates.tech>
| @pytest.mark.small_vm | ||
| @pytest.mark.big_vm | ||
| @pytest.mark.parametrize( | ||
| "fistpoint", |
There was a problem hiding this comment.
Just out of curiosity, what does 'fistpoint' mean here? I have a few ideas, but they don't really seem to fit? Is it kind of a joke?
I saw it in the code as well that is why I'm curious here :)
There was a problem hiding this comment.
Fistpoints are special files that are used to alter the behaviour of the smapi.
Basically, when present, they activates some sorts of breakpoints at specific points of the program.
We can trigger different kinds of callbacks, the default one is to pause for 10s. When combined with the exit_on_fistpoint fistpoint, it enforces a crash when reaching those breakpoints.
This is what makes the revert fail in controlled conditions, they are designed for end to end testing.
And yes, the name is funny, they exists since the first git commit of the sm project.
stormi
changed the title
|
I updated the title to indicate that although the PR is reviewed, we're waiting for the feature to be available in XCP-ng. |
stormi
changed the title
6 participants
This implements tests for
vdi_reverton file SRsRequired smapi changes xcp-ng/sm#124
Stacked PR review
vdi_reverton lvm based SRs #631