Skip to content

refactor(common): align hardhat task arguments and definitions#2163

Merged
mergify[bot] merged 2 commits intomainfrom
isaac/refactor/395/align-tasks-conventions
Mar 26, 2026
Merged

refactor(common): align hardhat task arguments and definitions#2163
mergify[bot] merged 2 commits intomainfrom
isaac/refactor/395/align-tasks-conventions

Conversation

@isaacdecoded
Copy link
Copy Markdown
Contributor

@isaacdecoded isaacdecoded requested a review from a team as a code owner March 24, 2026 11:27
@cla-bot cla-bot bot added the cla-signed label Mar 24, 2026
@isaacdecoded isaacdecoded force-pushed the isaac/refactor/395/align-tasks-conventions branch from 0bf76da to 322725a Compare March 24, 2026 11:31
Copy link
Copy Markdown
Contributor

@zmalatrax zmalatrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

host-contracts/tasks/taskUtils.ts still uses fs.readFileSync + dotenv.parse

File: host-contracts/tasks/taskUtils.ts:40,62

This file still has the old pattern with customKmsVerifierAddress / customInputVerifierAddress params and dotenv.parse(fs.readFileSync('addresses/.env.host')).

Copy link
Copy Markdown
Contributor

@zmalatrax zmalatrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gateway-contracts/tasks/reshareKeys.ts still uses inline dotenv.config

File: gateway-contracts/tasks/reshareKeys.ts:23,49

Two tasks (task:prssInit, task:keyReshareSameSet) already use useInternalProxyAddress and getRequiredEnvVar but call dotenv.config({ path: path.join(ADDRESSES_DIR, ".env.gateway"), override: true }) directly instead of using loadGatewayAddresses().

Since the gateway utils already have that helper, these should use it for consistency.

@isaacdecoded isaacdecoded requested a review from zmalatrax March 25, 2026 08:32
Copy link
Copy Markdown
Contributor

@zmalatrax zmalatrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@isaacdecoded
Copy link
Copy Markdown
Contributor Author

@Mergifyio queue

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 26, 2026

Merge Queue Status

This pull request spent 48 minutes 5 seconds in the queue, including 44 minutes 18 seconds running CI.

Required conditions to merge

mergify bot added a commit that referenced this pull request Mar 26, 2026
mergify bot added a commit that referenced this pull request Mar 26, 2026
@mergify mergify bot removed the merge-queued label Mar 26, 2026
@mergify mergify bot merged commit 6884332 into main Mar 26, 2026
64 of 65 checks passed
@mergify mergify bot deleted the isaac/refactor/395/align-tasks-conventions branch March 26, 2026 11:45
@mergify mergify bot removed the queued label Mar 26, 2026
mergify bot added a commit that referenced this pull request Mar 26, 2026
mergify bot added a commit that referenced this pull request Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants