Skip to content

Matrix: respect MSC3916, send bearer token when downloading images (#2184 #2205)#2225

Open
readthisusernamebackwards wants to merge 1 commit into42wim:masterfrom
readthisusernamebackwards:master
Open

Matrix: respect MSC3916, send bearer token when downloading images (#2184 #2205)#2225
readthisusernamebackwards wants to merge 1 commit into42wim:masterfrom
readthisusernamebackwards:master

Conversation

@readthisusernamebackwards

It doesn't seem like any form of org.matrix.msc3916 was ever advertised. All homeservers and homeserver software I've looked at supported the MSC3916 endpoint. I've thus simply switched the code over to it.

@mahdi1234
Copy link

Thank you very much! Works fine here for me (with media repo).

@antonizoon
Copy link

I tested and only merged #2225 since its simpler.

#2225

#2227

I'm going to start maintaining a fork of matterbridge to accept and merge pull requests regarding irc -> matrix -> discord since our organization needs this bridge to work.

However, I can only test irc -> matrix -> discord so will need more people to help provide pull requests proven to fix the whatsapp and telegram issues. If anyone else is able to help test whatsapp and telegram please provide tested pull requests.

https://github.com/bibanon/matterbridge/

Download linux intel 64-bit binary: https://github.com/bibanon/matterbridge/releases/tag/v1.26.1

@Wohlstand
Copy link

@antonizoon, going to make a test on my end too. I run a bridge between Discord, Matrix, XMPP, and Telegram.

@mahdi1234
Copy link

mahdi1234 commented Jun 2, 2025

@antonizoon same here, just deployed it running discord/irc/matrix/tele/xmpp.

Maybe we could setup matrix room for new bridge? I posted info about the bridge into old one, unfortunately the bot is dead so not bridged anymore.

@Wohlstand
Copy link

Maybe we could setup matrix room for new bridge? I posted info about the bridge into old one, unfortunately the bot is dead so not bridged anymore.

Sounds like you can't run just two instances of bot with the same login/password. You probably need to suspend the old bot and start new one if that's is not so critical. And if works just fine, then keep new bot, otherwise, revert to old one.

@mahdi1234
Copy link

Maybe we could setup matrix room for new bridge? I posted info about the bridge into old one, unfortunately the bot is dead so not bridged anymore.

Sounds like you can't run just two instances of bot with the same login/password. You probably need to suspend the old bot and start new one if that's is not so critical. And if works just fine, then keep new bot, otherwise, revert to old one.

That was suggestion to start chat for new bridge fork, so we can discuss instead here :)

Matterbridge project itself was bridged via mb, but that bot died, no issue on my side.

@antonizoon
Copy link

antonizoon commented Jun 2, 2025

@mahdi1234 I think its a good idea to stay in contact, especially if you might want to help with merging and testing pull requests for other group chat systems. I can only test irc, discord, matrix.

I had thought about posting a matrix/discord server, but currently if we are gathering users of the old fork to try to import pull requests, discussion should probably remain solely on github issues to be able to talk to and notify the relevant developers per issue directly and more importantly, publicly in a web searchable way. If it were in a separate group chat it might be a lot harder for new users and developers to find.

For stuff I aim to merge and test, I opened issues and pull requests on my fork for stuff I would investigate, ive merged quite a few already such as the dependabot crypto dependency, and discord reply bridging from graphene os.

https://github.com/bibanon/matterbridge/issues

https://github.com/bibanon/matterbridge/pulls?q=is%3Apr

@Wohlstand
Copy link

@antonizoon, Okay, now thing works flawless!
I also attempted to fix some bugs, like inability to delivery audio files from Matrix to other networks (they didn't recognized), and I will probably make a pull-request with that fix. Additionally I attempted to work around the problem when OGG audio file gets sent as a voice message when I supposed it should be sent like a normal audio file (like I send an OGG file via Telegram client), but no yet success. Addditionally, Go is not my language, just trying to apply some tweaks intuitively being C++ developer.

@antonizoon
Copy link

@Wohlstand sounds good. I dont see your pull request in this project or my github project, so if you can submit a pull request to either one (but for public information probably 42wim, I can merge it in from there) and I'll try merging it.

https://github.com/bibanon/matterbridge/pulls

@Wohlstand
Copy link

Sorry, I was busy, and I didn't yet compsed PRs yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants