Open
Conversation
Contributor
|
This is a do-not-merge branch right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
Current IK controller will directly apply the solved joint position to robot joints. For some of the robots, we actually want to use joint action space instead of ee_pos space as action to train BC policies. So we need to add a cache that stores intermediate joint actions.
Changes:
_latest_all_joint_angle_actioninWholeBodycontroller to store the latest joint action input_use_joint_angle_action_inputinWholeBodyto bypass the IK solving step. We can directly pass joint action instep()_use_joint_angle_action_inputin configs._use_joint_angle_action_inputin_validate_composite_controller_specific_config