Closed
Conversation
Collaborator
Author
This was referenced May 8, 2025
We create and then toss a large number of blocks at startup time. We do this because we randomly sample the state space with no rejections. Because of the way blocks are constructed it stands to reason that there are ranges of invalid samples and this structure is used to avoid those invalid ranges. Hyperfine results are now min 1.687, max 1.707 with the stdev reduced to 0.006 from 0.018. The block reject rate is now lower, which will improve our large entropy generation non-trivially. REF SMPTNG-659 Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/introduce_rejectset
branch
from
d2fb174 to
c86fe53
Compare
Collaborator
Author
|
Turns out, I've misread the situation. Most payloads do not suffer from high rejected block counts which strongly implies that either the otel metrics payload is buggy or is lacking sufficient information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We create and then toss a large number of blocks at startup time.
We do this because we randomly sample the state space with no rejections.
Because of the way blocks are constructed it stands to reason that there
are ranges of invalid samples and this structure is used to avoid those
invalid ranges.
Hyperfine results are now min 1.687, max 1.707 with the stdev reduced to
0.006 from 0.018. The block reject rate is now lower, which will improve
our large entropy generation non-trivially.
Motivation
REF SMPTNG-659