Introduce tag generator into OTel metrics payload by blt · Pull Request #1340 · DataDog/lading

blt · 2025-04-30T22:46:11Z

What does this PR do?

This commit introduces the generic tag generator into the otel metrics template code, allowing the attributes per to be obeyed.

Motivation

REF SMPTNG-659

blt · 2025-04-30T22:46:45Z

Introduce tag generator into OTel metrics payload #1340 : 2 dependent PRs (#1341 , #1342 ) 👈 (View in Graphite)
Add configuration validation for OTel metrics #1339
Bound contexts in Opentelemetry Metrics #1337
Generate units according to OTel required spec #1335
Generate OTel metrics with context limits #1331
Convert opentelemetry_metric to use MemberGenerator method #1326
Make tagset generation generic #1336
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

datadog-datadog-prod-us1 · 2025-05-12T21:46:04Z

Datadog Summary

✅ Code Quality ✅ Code Security ✅ Dependencies

Was this helpful? Give us feedback!

scottopell · 2025-05-15T16:14:32Z

lading_payload/src/opentelemetry_metric/tags.rs

+        // used by that generator: the generator maintains its own rng. It's a
+        // quirk of the trait.
+        //
+        // However DO NOT use this function's `rng` argument in any regard.


anything we can do to make this more obvious until we have a better solution?
eg maybe rename argument rng to rng_do_not_use_me or something

This comment echos verbage from the underlying generator. IIRC we've been okay for two years or something at this point. It does seem like a smell still, but I'm also hesitant to make a trait for this very specific case. I dunno, I feel like this comment makes the situation obvious. I'm happy to entertain any name changes though.

scottopell · 2025-05-15T16:15:32Z

lading_payload/src/opentelemetry_metric/tags.rs

+                .ok_or(Error::StringGenerate)?;
+            let val = self
+                .inner
+                .using_handle(tag.value)


nice, this is the API that supports generating directly into owned data it looks like?

This commit introduces the generic tag generator into the otel metrics template code, allowing the attributes per to be obeyed. REF SMPTNG-659 Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

blt · 2025-05-15T23:29:02Z

Merge activity

May 15, 7:29 PM EDT: @blt merged this pull request with Graphite.

blt added the no-changelog label Apr 30, 2025 — with Graphite App

blt marked this pull request as ready for review April 30, 2025 22:46

blt requested a review from a team as a code owner April 30, 2025 22:46

blt mentioned this pull request Apr 30, 2025

Bound contexts in Opentelemetry Metrics #1337

Merged

This was referenced Apr 30, 2025

Add configuration validation for OTel metrics #1339

Merged

Use prop_assert* in property tests #1341

Closed

Optimization passes for Otel metrics payload generation #1342

Merged

blt force-pushed the blt/add_configuration_validation_for_otel_metrics branch from c484f6a to bfe5e9d Compare May 8, 2025 18:46

blt force-pushed the blt/introduce_tag_generator_into_otel_metrics_payload branch from 7fb6ccc to 290b8f4 Compare May 8, 2025 18:46

This was referenced May 8, 2025

Introduce blockgen as an optimization target #1346

Closed

Introduce RejectSet #1347

Closed

blt force-pushed the blt/introduce_tag_generator_into_otel_metrics_payload branch from 290b8f4 to f0996d7 Compare May 8, 2025 19:02

blt force-pushed the blt/add_configuration_validation_for_otel_metrics branch 2 times, most recently from 7e8c002 to 6d6ec9a Compare May 8, 2025 19:14

blt force-pushed the blt/introduce_tag_generator_into_otel_metrics_payload branch from f0996d7 to 65e9d76 Compare May 8, 2025 19:14

blt force-pushed the blt/add_configuration_validation_for_otel_metrics branch from 6d6ec9a to dedcc09 Compare May 12, 2025 18:02

blt force-pushed the blt/introduce_tag_generator_into_otel_metrics_payload branch from 65e9d76 to f9c8702 Compare May 12, 2025 18:02

This was referenced May 12, 2025

Update payloadtool, block cache creation to have additional telemetry #1349

Merged

OTel Metric templates are direct protobuf types #1350

Merged

blt force-pushed the blt/add_configuration_validation_for_otel_metrics branch from dedcc09 to 82aa53b Compare May 12, 2025 21:43

blt force-pushed the blt/introduce_tag_generator_into_otel_metrics_payload branch from f9c8702 to 0e5e725 Compare May 12, 2025 21:43

blt force-pushed the blt/add_configuration_validation_for_otel_metrics branch from 82aa53b to f57d8f9 Compare May 12, 2025 21:46

blt force-pushed the blt/introduce_tag_generator_into_otel_metrics_payload branch from 0e5e725 to 50269bb Compare May 12, 2025 21:46

blt force-pushed the blt/introduce_tag_generator_into_otel_metrics_payload branch from 316ebaf to c2ded89 Compare May 15, 2025 15:59

scottopell approved these changes May 15, 2025

View reviewed changes

blt force-pushed the blt/add_configuration_validation_for_otel_metrics branch 2 times, most recently from b457687 to 5619433 Compare May 15, 2025 17:25

blt force-pushed the blt/introduce_tag_generator_into_otel_metrics_payload branch 2 times, most recently from c2a5afe to 44ee1a3 Compare May 15, 2025 22:59

blt force-pushed the blt/add_configuration_validation_for_otel_metrics branch from 5619433 to 44bf784 Compare May 15, 2025 22:59

blt mentioned this pull request May 15, 2025

Update metrics generation such that timestamps, sums are updated #1356

Merged

blt changed the base branch from blt/add_configuration_validation_for_otel_metrics to graphite-base/1340 May 15, 2025 23:14

blt added 10 commits May 15, 2025 23:14

Introduce tag generator into OTel metrics payload

8ada4a1

This commit introduces the generic tag generator into the otel metrics template code, allowing the attributes per to be obeyed. REF SMPTNG-659 Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

add otel metrics specific tags generator

a229bb1

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

adjust attributes per to u8 from u32 to match existing types

699a70d

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

comments

057654e

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

cargo check --tests passes

af36df6

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

fix broken rng chain

047b21b

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

tests pass

ff1004b

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

fix test regression detected

9bce2ea

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

property test checkpoint

07a2a1d

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

empty payloads are allowed

671a3b7

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

blt force-pushed the blt/introduce_tag_generator_into_otel_metrics_payload branch from 44ee1a3 to e610b10 Compare May 15, 2025 23:14

blt force-pushed the graphite-base/1340 branch from 44bf784 to e927680 Compare May 15, 2025 23:14

blt changed the base branch from graphite-base/1340 to main May 15, 2025 23:14

correct mut bug

11841e5

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

blt force-pushed the blt/introduce_tag_generator_into_otel_metrics_payload branch from e610b10 to 11841e5 Compare May 15, 2025 23:15

blt merged commit 231f9b9 into main May 15, 2025
21 checks passed

blt deleted the blt/introduce_tag_generator_into_otel_metrics_payload branch May 15, 2025 23:29

This was referenced May 17, 2025

Introduce data_points_transmitted / second in OTel metrics HTTP, GRPC #1357

Merged

Add OtlpMetric variant body to http generator #1364

Closed

Create Otlp specific blackhole #1365

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce tag generator into OTel metrics payload#1340

Introduce tag generator into OTel metrics payload#1340
blt merged 11 commits intomainfrom
blt/introduce_tag_generator_into_otel_metrics_payload

blt commented Apr 30, 2025 •

edited

Loading

Uh oh!

blt commented Apr 30, 2025 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1 bot commented May 12, 2025 •

edited

Loading

Uh oh!

scottopell May 15, 2025

Uh oh!

blt May 15, 2025

Uh oh!

scottopell May 15, 2025

Uh oh!

blt May 15, 2025

Uh oh!

Uh oh!

blt commented May 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

blt commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Uh oh!

blt commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datadog-datadog-prod-us1 bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Summary

Uh oh!

scottopell May 15, 2025

Choose a reason for hiding this comment

Uh oh!

blt May 15, 2025

Choose a reason for hiding this comment

Uh oh!

scottopell May 15, 2025

Choose a reason for hiding this comment

Uh oh!

blt May 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

blt commented May 15, 2025

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

blt commented Apr 30, 2025 •

edited

Loading

blt commented Apr 30, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented May 12, 2025 •

edited

Loading