Add configuration validation for OTel metrics#1339
Merged
Conversation
This was referenced Apr 30, 2025
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 30, 2025
blt
force-pushed
the
blt/add_configuration_validation_for_otel_metrics
branch
from
c484f6a to
bfe5e9d
Compare
blt
force-pushed
the
blt/bound_contexts_in_opentelemetry_metrics
branch
from
972f1c9 to
afd9721
Compare
This was referenced May 8, 2025
Closed
blt
force-pushed
the
blt/bound_contexts_in_opentelemetry_metrics
branch
from
afd9721 to
ff7beef
Compare
blt
force-pushed
the
blt/add_configuration_validation_for_otel_metrics
branch
2 times, most recently
from
7e8c002 to
6d6ec9a
Compare
blt
force-pushed
the
blt/bound_contexts_in_opentelemetry_metrics
branch
2 times, most recently
from
1d5cdf2 to
6f427f7
Compare
blt
force-pushed
the
blt/add_configuration_validation_for_otel_metrics
branch
from
6d6ec9a to
dedcc09
Compare
This was referenced May 12, 2025
blt
force-pushed
the
blt/add_configuration_validation_for_otel_metrics
branch
from
dedcc09 to
82aa53b
Compare
blt
force-pushed
the
blt/bound_contexts_in_opentelemetry_metrics
branch
from
6f427f7 to
02e8aa4
Compare
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies Was this helpful? Give us feedback! |
blt
force-pushed
the
blt/add_configuration_validation_for_otel_metrics
branch
from
82aa53b to
f57d8f9
Compare
blt
force-pushed
the
blt/add_configuration_validation_for_otel_metrics
branch
from
fc0cdd2 to
4820c51
Compare
blt
force-pushed
the
blt/bound_contexts_in_opentelemetry_metrics
branch
from
9e252a6 to
4bd9ed3
Compare
blt
force-pushed
the
blt/add_configuration_validation_for_otel_metrics
branch
from
4820c51 to
9664139
Compare
blt
force-pushed
the
blt/bound_contexts_in_opentelemetry_metrics
branch
from
4bd9ed3 to
da54724
Compare
blt
force-pushed
the
blt/add_configuration_validation_for_otel_metrics
branch
from
9664139 to
8044ee7
Compare
blt
force-pushed
the
blt/bound_contexts_in_opentelemetry_metrics
branch
from
da54724 to
556b3f3
Compare
blt
force-pushed
the
blt/add_configuration_validation_for_otel_metrics
branch
from
8044ee7 to
17c504f
Compare
blt
force-pushed
the
blt/bound_contexts_in_opentelemetry_metrics
branch
from
556b3f3 to
0966a3e
Compare
blt
force-pushed
the
blt/add_configuration_validation_for_otel_metrics
branch
2 times, most recently
from
c103524 to
d23dbc3
Compare
blt
force-pushed
the
blt/bound_contexts_in_opentelemetry_metrics
branch
from
922e878 to
c0e8cb9
Compare
blt
force-pushed
the
blt/add_configuration_validation_for_otel_metrics
branch
from
d23dbc3 to
1fd813e
Compare
blt
force-pushed
the
blt/bound_contexts_in_opentelemetry_metrics
branch
2 times, most recently
from
ff661c3 to
de3a40b
Compare
blt
force-pushed
the
blt/add_configuration_validation_for_otel_metrics
branch
from
1fd813e to
c550638
Compare
scottopell
approved these changes
May 15, 2025
| // Validate that the requested contexts are achievable | ||
| if min_contexts > max_configured { | ||
| return Err(format!( | ||
| "Minimum requested contexts {min_contexts} cannot be achieved with current configuration (max possible: {max_configured})" |
Contributor
There was a problem hiding this comment.
nice addition, this validation is very helpful (and annoying and tricky to write), thanks for adding this in.
blt
changed the base branch from
blt/bound_contexts_in_opentelemetry_metrics
to
graphite-base/1339
blt
force-pushed
the
blt/add_configuration_validation_for_otel_metrics
branch
from
c550638 to
b457687
Compare
blt
force-pushed
the
blt/add_configuration_validation_for_otel_metrics
branch
from
b457687 to
5619433
Compare
This commit adds validation cases to the OTel metrics payload generator. To date we have not done that much to guide users in getting a good configuration of lading but in this payload we have sufficient information to be of some help. REF SMPTNG-659 Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/add_configuration_validation_for_otel_metrics
branch
from
5619433 to
44bf784
Compare
Collaborator
Author
This was referenced May 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit adds validation cases to the OTel metrics payload
generator. To date we have not done that much to guide users in
getting a good configuration of lading but in this payload we have
sufficient information to be of some help.
Motivation
REF SMPTNG-659