enhancement(antithesis): floor buffer size, multi-value packed metrics by blt · Pull Request #1799 · DataDog/saluki

blt · 2026-06-02T15:59:36Z

Summary

Expand the antithesis rig to:

ship multi-value metric lines to ADP
ensure that dogstatsd_buffer_size is mostly larger than 128 bytes without excluding smaller values and
tidy up an assertion name to reflect actual semantics around sends.

Change Type

Bug fix
New feature
Non-functional (chore, refactoring, docs)
Performance

How did you test this PR?

Run under antithesis.

References

N/A

blt · 2026-06-02T15:59:56Z

enhancement(antithesis): floor buffer size, multi-value packed metrics #1799 : 2 dependent PRs (#1800 , #1826 ) 👈 (View in Graphite)
chore(antithesis): untrack scratchbook and add to .gitignore #1905
enhancement(antithesis): Expand SDK assertions, hammer sketch #1785
enhancement(antithesis): DogStatsD load generation #1782
enhancement(antithesis): Vary datadog.yaml in test/antithesis, assert aliveness #1779
docs(antithesis): Antithesis research scratchbook and bug ledger #1768 : 2 other dependent PRs (#1769 , #1787 )
chore(antithesis): Antithesis test harness and workload #1767
enhancement(correctness): Create test/antithesis sub-project #1774
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

pr-commenter · 2026-06-02T16:08:17Z

Binary Size Analysis (Agent Data Plane)

Baseline: 1dcffdf · Comparison: e2f4b11 · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 40.33 MiB (baseline) vs 40.33 MiB (comparison)
Size Change: +0 B (+0.00%)

✅ Binary size difference within threshold

Changes by Module

Module	File Size	Symbols
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.12925350276612521567`	+130 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.9780492707523803669`	-129 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.12925350276612521567`	+115 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.9780492707523803669`	-114 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.12925350276612521567`	+109 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.9780492707523803669`	-108 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.12925350276612521567`	+97 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.9780492707523803669`	-96 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.12925350276612521567`	+95 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.9780492707523803669`	-94 B	1
`[Unmapped]`	-5 B	1

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW]    +130  [NEW]     +40    anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.12925350276612521567
  [NEW]    +115  [NEW]     +25    anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.12925350276612521567
  [NEW]    +109  [NEW]     +19    anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.12925350276612521567
  [NEW]     +97  [NEW]      +7    anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.12925350276612521567
  [NEW]     +95  [NEW]      +5    anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.12925350276612521567
  -0.1%      -5  [ = ]       0    [Unmapped]
  [DEL]     -94  [DEL]      -5    anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.9780492707523803669
  [DEL]     -96  [DEL]      -7    anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.9780492707523803669
  [DEL]    -108  [DEL]     -19    anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.9780492707523803669
  [DEL]    -114  [DEL]     -25    anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.9780492707523803669
  [DEL]    -129  [DEL]     -40    anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.9780492707523803669
  [ = ]       0  [ = ]       0    TOTAL

pr-commenter · 2026-06-02T16:24:04Z

Regression Detector (Agent Data Plane)

Run ID: b8187aff-2cf2-481c-a611-55f60ce0b5cb
Baseline: 1dcffdf3 · Comparison: e2f4b113 · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (35)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment	goal	Δ mean %	links
dsd_uds_512kb_3k_contexts_cpu (erratic)	cpu	⚪ +6.13	metrics profiles logs
dsd_uds_1mb_3k_contexts_cpu (erratic)	cpu	⚪ +3.15	metrics profiles logs
otlp_ingest_logs_5mb_memory (ignored)	memory	⚪ +2.78	metrics profiles logs
otlp_ingest_traces_ottl_filtering_5mb_cpu (erratic)	cpu	⚪ +2.64	metrics profiles logs
otlp_ingest_logs_5mb_cpu (ignored)	cpu	⚪ +2.42	metrics profiles logs
dsd_uds_10mb_3k_contexts_cpu (erratic)	cpu	⚪ +1.87	metrics profiles logs
dsd_uds_10mb_3k_contexts_memory	memory	⚪ +0.79	metrics profiles logs
dsd_uds_500mb_3k_contexts_cpu (erratic)	cpu	⚪ +0.55	metrics profiles logs
dsd_uds_100mb_3k_contexts_memory	memory	⚪ +0.51	metrics profiles logs
dsd_uds_500mb_3k_contexts_memory	memory	⚪ +0.43	metrics profiles logs
otlp_ingest_metrics_5mb_cpu (erratic)	cpu	⚪ +0.28	metrics profiles logs
otlp_ingest_traces_ottl_filtering_5mb_memory	memory	⚪ +0.20	metrics profiles logs
otlp_ingest_traces_ottl_transform_5mb_throughput	throughput	⚪ -0.03	metrics profiles logs
dsd_uds_10mb_3k_contexts_throughput	throughput	⚪ -0.01	metrics profiles logs
quality_gates_rss_dsd_heavy	memory	⚪ +0.01	metrics profiles logs
otlp_ingest_metrics_5mb_throughput	throughput	⚪ -0.01	metrics profiles logs
dsd_uds_1mb_3k_contexts_throughput	throughput	⚪ -0.00	metrics profiles logs
dsd_uds_100mb_3k_contexts_throughput	throughput	⚪ +0.00	metrics profiles logs
dsd_uds_512kb_3k_contexts_throughput	throughput	⚪ +0.00	metrics profiles logs
otlp_ingest_logs_5mb_throughput (ignored)	throughput	⚪ +0.02	metrics profiles logs
dsd_uds_1mb_3k_contexts_memory	memory	⚪ -0.04	metrics profiles logs
otlp_ingest_traces_ottl_filtering_5mb_throughput	throughput	⚪ +0.06	metrics profiles logs
otlp_ingest_traces_ottl_transform_5mb_memory	memory	⚪ -0.07	metrics profiles logs
dsd_uds_500mb_3k_contexts_throughput	throughput	⚪ +0.12	metrics profiles logs
quality_gates_rss_idle	memory	⚪ -0.16	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory	⚪ -0.19	metrics profiles logs
otlp_ingest_traces_5mb_throughput	throughput	⚪ +0.24	metrics profiles logs
dsd_uds_512kb_3k_contexts_memory	memory	⚪ -0.30	metrics profiles logs
quality_gates_rss_dsd_low	memory	⚪ -0.30	metrics profiles logs
otlp_ingest_traces_5mb_memory	memory	⚪ -0.46	metrics profiles logs
otlp_ingest_traces_5mb_cpu (erratic)	cpu	⚪ -0.65	metrics profiles logs
quality_gates_rss_dsd_medium	memory	⚪ -0.66	metrics profiles logs
dsd_uds_100mb_3k_contexts_cpu (erratic)	cpu	⚪ -1.13	metrics profiles logs
otlp_ingest_traces_ottl_transform_5mb_cpu (erratic)	cpu	⚪ -1.23	metrics profiles logs
otlp_ingest_metrics_5mb_memory	memory	⚪ -4.22	metrics profiles logs

Bounds Checks: ✅ Passed (5)

experiment	check	replicates	observed	links
quality_gates_rss_dsd_heavy	memory_usage	10/10	✅ 131 MiB ≤ 140 MiB	metrics profiles logs
quality_gates_rss_dsd_low	memory_usage	10/10	✅ 42.3 MiB ≤ 50 MiB	metrics profiles logs
quality_gates_rss_dsd_medium	memory_usage	10/10	✅ 65.9 MiB ≤ 75 MiB	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory_usage	10/10	✅ 191 MiB ≤ 200 MiB	metrics profiles logs
quality_gates_rss_idle	memory_usage	10/10	✅ 28.2 MiB ≤ 40 MiB	metrics profiles logs

Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Sample dogstatsd_buffer_size mostly >=128 so a tiny buffer does not silently zero delivery. Emit multi-value :-packed metrics ~5% with a Sometimes anchor. Rename the send-success anchor to 'workload sent a dogstatsd line'.

blt mentioned this pull request Jun 2, 2026

enhancement(antithesis): Vary datadog.yaml in test/antithesis, assert aliveness #1779

Merged

4 tasks

dd-octo-sts Bot added the area/test All things testing: unit/integration, correctness, SMP regression, etc. label Jun 2, 2026

blt mentioned this pull request Jun 2, 2026

enhancement(antithesis): DogStatsD load generation #1782

Merged

4 tasks

This was referenced Jun 2, 2026

enhancement(antithesis): Expand SDK assertions, hammer sketch #1785

Merged

enhancement(antithesis): enable forwarder disk persistence #1800

Closed

This comment has been minimized.

Sign in to view

blt force-pushed the blt/antithesis_sdk_assertions_in_SUT branch from 32a48db to 7893e8b Compare June 2, 2026 16:26

blt force-pushed the blt/antithesis-workload-sampling branch from dd0c580 to 6945527 Compare June 2, 2026 16:26

blt force-pushed the blt/antithesis_sdk_assertions_in_SUT branch from 7893e8b to c68f7bf Compare June 2, 2026 20:16

blt force-pushed the blt/antithesis-workload-sampling branch 2 times, most recently from 6e47ff1 to b291254 Compare June 2, 2026 20:33

blt force-pushed the blt/antithesis_sdk_assertions_in_SUT branch 2 times, most recently from 2dbd8ab to 36bc156 Compare June 2, 2026 20:48

blt force-pushed the blt/antithesis-workload-sampling branch from b291254 to 2ac1e74 Compare June 2, 2026 20:48

blt force-pushed the blt/antithesis_sdk_assertions_in_SUT branch from 36bc156 to 2c739f2 Compare June 2, 2026 21:00

blt force-pushed the blt/antithesis-workload-sampling branch from 2ac1e74 to 90323e5 Compare June 2, 2026 21:00

blt force-pushed the blt/antithesis_sdk_assertions_in_SUT branch from 2c739f2 to cd5fbd8 Compare June 2, 2026 21:27

blt force-pushed the blt/antithesis-workload-sampling branch from 90323e5 to 5a9453c Compare June 2, 2026 21:27

blt force-pushed the blt/antithesis_sdk_assertions_in_SUT branch from cd5fbd8 to 83797ef Compare June 2, 2026 21:37

blt force-pushed the blt/antithesis-workload-sampling branch 2 times, most recently from e5880cc to 3662eca Compare June 2, 2026 22:26

blt force-pushed the blt/antithesis_sdk_assertions_in_SUT branch 2 times, most recently from 63eded0 to 76f6d9b Compare June 2, 2026 22:47

blt force-pushed the blt/antithesis-workload-sampling branch 2 times, most recently from 648ccda to ed10986 Compare June 2, 2026 23:36

blt marked this pull request as ready for review June 2, 2026 23:39

blt requested a review from a team as a code owner June 2, 2026 23:39

Copilot AI reviewed Jun 15, 2026

View reviewed changes

Comment thread test/antithesis/harness/src/bin/parallel_driver_send_dogstatsd.rs Outdated

Comment thread test/antithesis/scratchbook/existing-assertions.md Outdated

Comment thread test/antithesis/scratchbook/existing-assertions.md Outdated

blt force-pushed the blt/antithesis-workload-sampling branch from 323267a to 8c7b55d Compare June 15, 2026 22:44

This was referenced Jun 18, 2026

enhancement(antithesis): Move antithesis/deploy to scenarios/general #1890

Merged

chore(antithesis): Differential comparison between ADP and Datadog Agent context egress #1891

Merged

Copilot AI review requested due to automatic review settings June 18, 2026 21:34

blt force-pushed the blt/antithesis-workload-sampling branch from 8c7b55d to 084d401 Compare June 18, 2026 21:34

blt force-pushed the blt/antithesis_sdk_assertions_in_SUT branch from 46f5fe5 to 516eee0 Compare June 18, 2026 21:34

Copilot started reviewing on behalf of blt June 18, 2026 21:34 View session

Copilot AI reviewed Jun 18, 2026

View reviewed changes

Comment thread test/antithesis/scratchbook/existing-assertions.md Outdated

Comment thread test/antithesis/harness/src/bin/parallel_driver_send_dogstatsd.rs

Comment thread test/antithesis/harness/src/bin/first_sample_config/config.rs

This was referenced Jun 18, 2026

chore(antithesis): split intake HTTP modules #1892

Merged

enhancement(antithesis): accept Datadog intake endpoints #1893

Merged

blt force-pushed the blt/antithesis_sdk_assertions_in_SUT branch from 516eee0 to 85bc7a9 Compare June 22, 2026 18:48

blt force-pushed the blt/antithesis-workload-sampling branch from 084d401 to 07d1980 Compare June 22, 2026 18:48

blt changed the base branch from blt/antithesis_sdk_assertions_in_SUT to graphite-base/1799 June 22, 2026 19:05

Copilot AI review requested due to automatic review settings June 22, 2026 19:05

blt force-pushed the blt/antithesis-workload-sampling branch from 07d1980 to ecdc5df Compare June 22, 2026 19:05

blt changed the base branch from graphite-base/1799 to blt/untrack_antithesis_scratchbook June 22, 2026 19:05

Copilot started reviewing on behalf of blt June 22, 2026 19:05 View session

blt mentioned this pull request Jun 22, 2026

chore(antithesis): untrack scratchbook and add to .gitignore #1905

Merged

4 tasks

Copilot AI reviewed Jun 22, 2026

View reviewed changes

blt force-pushed the blt/antithesis-workload-sampling branch from ecdc5df to eb2197b Compare June 22, 2026 20:58

blt force-pushed the blt/untrack_antithesis_scratchbook branch 3 times, most recently from 0449c6e to 673a305 Compare June 22, 2026 21:30

blt force-pushed the blt/antithesis-workload-sampling branch from eb2197b to 2c2e517 Compare June 22, 2026 21:30

blt changed the base branch from blt/untrack_antithesis_scratchbook to graphite-base/1799 June 22, 2026 21:55

blt force-pushed the graphite-base/1799 branch from 673a305 to 1dcffdf Compare June 22, 2026 21:55

blt force-pushed the blt/antithesis-workload-sampling branch from 2c2e517 to ac0fdda Compare June 22, 2026 21:55

test(antithesis): floor buffer size, multi-value packed metrics

e2f4b11

Sample dogstatsd_buffer_size mostly >=128 so a tiny buffer does not silently zero delivery. Emit multi-value :-packed metrics ~5% with a Sometimes anchor. Rename the send-success anchor to 'workload sent a dogstatsd line'.

tobz approved these changes Jun 23, 2026

View reviewed changes

Navigation Menu

Uh oh!

enhancement(antithesis): floor buffer size, multi-value packed metrics - #1799

enhancement(antithesis): floor buffer size, multi-value packed metrics#1799
tobz merged 1 commit into
mainfrom
blt/antithesis-workload-sampling

blt commented Jun 2, 2026 •

edited

Loading

Uh oh!

blt commented Jun 2, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

pr-commenter Bot commented Jun 2, 2026 •

edited

Loading

Uh oh!

pr-commenter Bot commented Jun 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

blt commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Change Type

How did you test this PR?

References

Uh oh!

blt commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

pr-commenter Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Size Analysis (Agent Data Plane)

✅ Binary size difference within threshold

Uh oh!

pr-commenter Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector (Agent Data Plane)

Optimization Goals: ✅ No significant changes detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

blt commented Jun 2, 2026 •

edited

Loading

blt commented Jun 2, 2026 •

edited

Loading

pr-commenter Bot commented Jun 2, 2026 •

edited

Loading

pr-commenter Bot commented Jun 2, 2026 •

edited

Loading