chore(antithesis): untrack scratchbook and add to .gitignore - #1905
Merged
Conversation
This was referenced Jun 22, 2026
dd-octo-sts
Bot
added
the
area/test
This was referenced Jun 22, 2026
Merged
Contributor
Author
4 tasks
This comment has been minimized.
This comment has been minimized.
Binary Size Analysis (Agent Data Plane)Baseline: 67ea81b · Comparison: 673a305 · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14f2363fce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR removes the Antithesis “scratchbook” Markdown docs from version control and prevents the directory from being re-added by adding it to .gitignore, reducing noise from automated reviewers/CI bots on frequently-changing research notes.
Changes:
- Deleted the tracked
test/antithesis/scratchbook/**Markdown documents. - Added
test/antithesis/scratchbook/to.gitignoreso future scratchbook changes remain untracked.
Reviewed changes
Copilot reviewed 50 out of 52 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.gitignore |
Ignores test/antithesis/scratchbook/ to keep scratchbook content untracked going forward. |
test/antithesis/scratchbook/workload-sampling-design.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/existing-assertions.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/bug-ledger.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/evaluation/synthesis.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/adp-keeps-delivering.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/adp-stays-alive.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/aggregate-clock-skew-stable.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/aggregate-context-limit-enforced.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/aggregate-matches-agent.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/aggregate-no-panic-any-window.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/config-incompatible-refuses-start.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/config-runtime-update-not-revalidated.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/config-stall-no-deadlock.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/data-component-failure-triggers-process-shutdown.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/ddsketch-bin-count-bounded.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/ddsketch-relative-error-bound.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/disk-persisted-retry-survives-restart.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/events-sc-no-silent-loss.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/events-sc-pipeline-reachable.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/filter-config-reload-correct.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/forwarder-eventual-delivery.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/graceful-shutdown-within-30s.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/interner-full-bounded.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/interner-reclamation-no-corruption.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/malformed-dsd-no-crash.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/malformed-event-sc-no-crash.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/mapper-interner-bounded.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/mapper-output-matches-agent.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/memory-limiter-survives-rss-read-failure.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/no-silent-interconnect-drop.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/non-finite-values-handled-consistently.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/prefix-filter-ordering-matches-agent.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/replay-corruption-not-silent-eof.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/replay-no-panic-on-malformed-capture.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/retry-queue-bounded-under-outage.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/rss-bounded-under-cardinality.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/shutdown-drains-no-loss.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/source-dispatch-no-misroute.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/tag-filterlist-applied-consistently.md |
Removed tracked scratchbook note. |
test/antithesis/scratchbook/properties/topology-ready-before-intake.md |
Removed tracked scratchbook note. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jszwedko
approved these changes
Jun 22, 2026
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (35)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
blt
force-pushed
the
blt/untrack_antithesis_scratchbook
branch
from
June 22, 2026 20:58
14f2363 to
db43eb1
Compare
blt
force-pushed
the
blt/antithesis_sdk_assertions_in_SUT
branch
from
June 22, 2026 20:58
85bc7a9 to
77ba1c6
Compare
blt
changed the base branch from
blt/antithesis_sdk_assertions_in_SUT
to
graphite-base/1905
June 22, 2026 21:29
blt
force-pushed
the
blt/untrack_antithesis_scratchbook
branch
from
June 22, 2026 21:29
db43eb1 to
0449c6e
Compare
Remove the antithesis skill scratchbook from git tracking. While theoretically this is maintained automatically in practice the scratchbook attracts CI review robots in a way I find tedious to deal with. Too bad, so sad, goodbye scratchbook.
blt
force-pushed
the
blt/untrack_antithesis_scratchbook
branch
from
June 22, 2026 21:30
0449c6e to
673a305
Compare
Contributor
Author
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Jun 22, 2026
## Summary <!-- Please provide a brief summary about what this PR does. This should help the reviewers give feedback faster and with higher quality. --> Remove the antithesis skill scratchbook from git tracking. While theoretically this is maintained automatically in practice the scratchbook attracts CI review robots in a way I find tedious to deal with. Too bad, so sad, goodbye scratchbook. ## Change Type - [ ] Bug fix - [ ] New feature - [x] Non-functional (chore, refactoring, docs) - [ ] Performance ## How did you test this PR? <!-- Please how you tested these changes here --> ## References <!-- Please list any issues closed by this PR. --> <!-- - Closes: <issue link> --> <!-- Any other issues or PRs relevant to this PR? Feel free to list them here. --> 1dcffdf
tobz
pushed a commit
that referenced
this pull request
Jun 30, 2026
## Summary <!-- Please provide a brief summary about what this PR does. This should help the reviewers give feedback faster and with higher quality. --> Remove the antithesis skill scratchbook from git tracking. While theoretically this is maintained automatically in practice the scratchbook attracts CI review robots in a way I find tedious to deal with. Too bad, so sad, goodbye scratchbook. ## Change Type - [ ] Bug fix - [ ] New feature - [x] Non-functional (chore, refactoring, docs) - [ ] Performance ## How did you test this PR? <!-- Please how you tested these changes here --> ## References <!-- Please list any issues closed by this PR. --> <!-- - Closes: <issue link> --> <!-- Any other issues or PRs relevant to this PR? Feel free to list them here. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the antithesis skill scratchbook from git tracking. While
theoretically this is maintained automatically in practice the
scratchbook attracts CI review robots in a way I find tedious to deal
with. Too bad, so sad, goodbye scratchbook.
Change Type
How did you test this PR?
References